2022-08-25 12:42:44

by Jilin Yuan

Subject: [PATCH] drivers/ata: fix repeated words in comments

Delete the redundant word 'in'.
Delete the redundant word 'to'.

Signed-off-by: Jilin Yuan <[email protected]>
---
drivers/ata/libata-eh.c | 2 +-
drivers/ata/pata_macio.c | 2 +-
drivers/ata/sata_dwc_460ex.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 7c128c89b454..ca865a95cf24 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
*
* Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
* is non-zero and EH wasn't pending before. Fast drain ensures
- * that EH kicks in in timely manner.
+ * that EH kicks in timely manner.
*
* LOCKING:
* spin_lock_irqsave(host lock)
diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
index bfea2be2959a..076212fdb9d9 100644
--- a/drivers/ata/pata_macio.c
+++ b/drivers/ata/pata_macio.c
@@ -666,7 +666,7 @@ static u8 pata_macio_bmdma_status(struct ata_port *ap)
* a multi-block transfer.
*
* - The dbdma fifo hasn't yet finished flushing to
- * to system memory when the disk interrupt occurs.
+ * system memory when the disk interrupt occurs.
*
*/

diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
index e3263e961045..a4c83a6e5631 100644
--- a/drivers/ata/sata_dwc_460ex.c
+++ b/drivers/ata/sata_dwc_460ex.c
@@ -1087,7 +1087,7 @@ static struct scsi_host_template sata_dwc_sht = {
/*
* test-only: Currently this driver doesn't handle NCQ
* correctly. We enable NCQ but set the queue depth to a
- * max of 1. This will get fixed in in a future release.
+ * max of 1. This will get fixed in a future release.
*/
.sg_tablesize = LIBATA_MAX_PRD,
/* .can_queue = ATA_MAX_QUEUE, */
--
2.36.1

2022-08-25 23:12:36

by Damien Le Moal

Subject: Re: [PATCH] drivers/ata: fix repeated words in comments

On 8/25/22 21:36, Jilin Yuan wrote:
> Delete the redundant word 'in'.
> Delete the redundant word 'to'.


> Signed-off-by: Jilin Yuan <[email protected]>
> ---
> drivers/ata/libata-eh.c | 2 +-
> drivers/ata/pata_macio.c | 2 +-
> drivers/ata/sata_dwc_460ex.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
> index 7c128c89b454..ca865a95cf24 100644
> --- a/drivers/ata/libata-eh.c
> +++ b/drivers/ata/libata-eh.c
> @@ -863,7 +863,7 @@ void ata_eh_fastdrain_timerfn(struct timer_list *t)
> *
> * Set ATA_PFLAG_EH_PENDING and activate fast drain if @fastdrain
> * is non-zero and EH wasn't pending before. Fast drain ensures
> - * that EH kicks in in timely manner.
> + * that EH kicks in timely manner.

As already commented, this fix is not correct. The sentence should read:

that EH kicks-in in a timely manner.

The patch title for this fix should be:

ata: libata-eh: fix repeated words in comment

> *
> * LOCKING:
> * spin_lock_irqsave(host lock)
> diff --git a/drivers/ata/pata_macio.c b/drivers/ata/pata_macio.c
> index bfea2be2959a..076212fdb9d9 100644
> --- a/drivers/ata/pata_macio.c
> +++ b/drivers/ata/pata_macio.c
> @@ -666,7 +666,7 @@ static u8 pata_macio_bmdma_status(struct ata_port *ap)
> * a multi-block transfer.
> *
> * - The dbdma fifo hasn't yet finished flushing to
> - * to system memory when the disk interrupt occurs.
> + * system memory when the disk interrupt occurs.
> *

While at it, please remove the above useless extra "*" line.

> */
>
> diff --git a/drivers/ata/sata_dwc_460ex.c b/drivers/ata/sata_dwc_460ex.c
> index e3263e961045..a4c83a6e5631 100644
> --- a/drivers/ata/sata_dwc_460ex.c
> +++ b/drivers/ata/sata_dwc_460ex.c
> @@ -1087,7 +1087,7 @@ static struct scsi_host_template sata_dwc_sht = {
> /*
> * test-only: Currently this driver doesn't handle NCQ
> * correctly. We enable NCQ but set the queue depth to a
> - * max of 1. This will get fixed in in a future release.
> + * max of 1. This will get fixed in a future release.
> */
> .sg_tablesize = LIBATA_MAX_PRD,
> /* .can_queue = ATA_MAX_QUEUE, */

Please move this second hunk to a different patch with the title:

ata: sata_dwc_460ex: fix repeated words in comment

--
Damien Le Moal
Western Digital Research