2022-08-26 03:04:01

by CGEL

Subject: [PATCH linux-next] admin-guide: cgroup: fix a typo in description

From: lufengchang <[email protected]>

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: lufengchang <[email protected]>
---
Documentation/admin-guide/cgroup-v1/cgroups.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/admin-guide/cgroup-v1/cgroups.rst b/Documentation/admin-guide/cgroup-v1/cgroups.rst
index b0688011ed06..fa747466e304 100644
--- a/Documentation/admin-guide/cgroup-v1/cgroups.rst
+++ b/Documentation/admin-guide/cgroup-v1/cgroups.rst
@@ -573,7 +573,7 @@ cgroup_for_each_descendant_pre() for details.
``void css_offline(struct cgroup *cgrp);``
(cgroup_mutex held by caller)

-This is the counterpart of css_online() and called iff css_online()
+This is the counterpart of css_online() and called if css_online()
has succeeded on @cgrp. This signifies the beginning of the end of
@cgrp. @cgrp is being removed and the subsystem should start dropping
all references it's holding on @cgrp. When all references are dropped,
--
2.25.1

2022-08-26 03:11:20

by Randy Dunlap

Subject: Re: [PATCH linux-next] admin-guide: cgroup: fix a typo in description

Hi,

On 8/25/22 19:05, [email protected] wrote:
> From: lufengchang <[email protected]>
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: lufengchang <[email protected]>

Are you sure that it's a typo?

https://en.wikipedia.org/wiki/If_and_only_if

"iff" is commonly used (in math/technical literature)
to mean "if and only if".

> ---
> Documentation/admin-guide/cgroup-v1/cgroups.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/admin-guide/cgroup-v1/cgroups.rst b/Documentation/admin-guide/cgroup-v1/cgroups.rst
> index b0688011ed06..fa747466e304 100644
> --- a/Documentation/admin-guide/cgroup-v1/cgroups.rst
> +++ b/Documentation/admin-guide/cgroup-v1/cgroups.rst
> @@ -573,7 +573,7 @@ cgroup_for_each_descendant_pre() for details.
> ``void css_offline(struct cgroup *cgrp);``
> (cgroup_mutex held by caller)
>
> -This is the counterpart of css_online() and called iff css_online()
> +This is the counterpart of css_online() and called if css_online()
> has succeeded on @cgrp. This signifies the beginning of the end of
> @cgrp. @cgrp is being removed and the subsystem should start dropping
> all references it's holding on @cgrp. When all references are dropped,

--
~Randy