2022-08-26 10:06:21

by Jules Maselbas

[permalink] [raw]
Subject: [PATCH] media: i2c: Fix repeated word in comments

Remove redundant word `the`.

CC: Jacopo Mondi <[email protected]>
CC: [email protected]
Signed-off-by: Jules Maselbas <[email protected]>
---
drivers/media/i2c/mt9v111.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
index 2dc4a0f24ce8..7beca0b70b72 100644
--- a/drivers/media/i2c/mt9v111.c
+++ b/drivers/media/i2c/mt9v111.c
@@ -633,7 +633,7 @@ static int mt9v111_hw_config(struct mt9v111_dev *mt9v111)

/*
* Set pixel integration time to the whole frame time.
- * This value controls the the shutter delay when running with AE
+ * This value controls the shutter delay when running with AE
* disabled. If longer than frame time, it affects the output
* frame rate.
*/
--
2.17.1


2022-08-26 11:25:23

by jacopo mondi

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: Fix repeated word in comments

Hi Jules

thanks, but as reported in patchwork and lore
https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=mt9v111&archive=both&delegate=
https://lore.kernel.org/all/[email protected]/

This is the 4th patch to fix the same repeated word in a comment.

As I asked to Jilin, are you submitting this as part of a new
contributor program ?

Thanks
j

On Fri, Aug 26, 2022 at 12:00:50PM +0200, Jules Maselbas wrote:
> Remove redundant word `the`.
>
> CC: Jacopo Mondi <[email protected]>
> CC: [email protected]
> Signed-off-by: Jules Maselbas <[email protected]>
> ---
> drivers/media/i2c/mt9v111.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> index 2dc4a0f24ce8..7beca0b70b72 100644
> --- a/drivers/media/i2c/mt9v111.c
> +++ b/drivers/media/i2c/mt9v111.c
> @@ -633,7 +633,7 @@ static int mt9v111_hw_config(struct mt9v111_dev *mt9v111)
>
> /*
> * Set pixel integration time to the whole frame time.
> - * This value controls the the shutter delay when running with AE
> + * This value controls the shutter delay when running with AE
> * disabled. If longer than frame time, it affects the output
> * frame rate.
> */
> --
> 2.17.1
>

2022-08-26 11:41:37

by Hans Verkuil

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: Fix repeated word in comments

I'm rejecting these patches in patchwork. All (or almost all) are duplicates.

Regards,

Hans

On 8/26/22 12:24, Jacopo Mondi wrote:
> Hi Jules
>
> thanks, but as reported in patchwork and lore
> https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=mt9v111&archive=both&delegate=
> https://lore.kernel.org/all/[email protected]/
>
> This is the 4th patch to fix the same repeated word in a comment.
>
> As I asked to Jilin, are you submitting this as part of a new
> contributor program ?
>
> Thanks
> j
>
> On Fri, Aug 26, 2022 at 12:00:50PM +0200, Jules Maselbas wrote:
>> Remove redundant word `the`.
>>
>> CC: Jacopo Mondi <[email protected]>
>> CC: [email protected]
>> Signed-off-by: Jules Maselbas <[email protected]>
>> ---
>> drivers/media/i2c/mt9v111.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
>> index 2dc4a0f24ce8..7beca0b70b72 100644
>> --- a/drivers/media/i2c/mt9v111.c
>> +++ b/drivers/media/i2c/mt9v111.c
>> @@ -633,7 +633,7 @@ static int mt9v111_hw_config(struct mt9v111_dev *mt9v111)
>>
>> /*
>> * Set pixel integration time to the whole frame time.
>> - * This value controls the the shutter delay when running with AE
>> + * This value controls the shutter delay when running with AE
>> * disabled. If longer than frame time, it affects the output
>> * frame rate.
>> */
>> --
>> 2.17.1
>>

2022-08-26 12:50:46

by Jules Maselbas

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: Fix repeated word in comments

Hi Jacopo,

On Fri, Aug 26, 2022 at 12:24:47PM +0200, Jacopo Mondi wrote:
> Hi Jules
>
> thanks, but as reported in patchwork and lore
> https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=mt9v111&archive=both&delegate=
> https://lore.kernel.org/all/[email protected]/
>
> This is the 4th patch to fix the same repeated word in a comment.

> As I asked to Jilin, are you submitting this as part of a new
> contributor program ?
No, I've search for more repeated word after I've found one (in dma-buf heaps).
I then saw that there were already some fixed by Jilin Yuan (and
probably others).

I was expecting that some patches were sent for this, sorry for the noise.

Cheers

> Thanks
> j
>
> On Fri, Aug 26, 2022 at 12:00:50PM +0200, Jules Maselbas wrote:
> > Remove redundant word `the`.
> >
> > CC: Jacopo Mondi <[email protected]>
> > CC: [email protected]
> > Signed-off-by: Jules Maselbas <[email protected]>
> > ---
> > drivers/media/i2c/mt9v111.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> > index 2dc4a0f24ce8..7beca0b70b72 100644
> > --- a/drivers/media/i2c/mt9v111.c
> > +++ b/drivers/media/i2c/mt9v111.c
> > @@ -633,7 +633,7 @@ static int mt9v111_hw_config(struct mt9v111_dev *mt9v111)
> >
> > /*
> > * Set pixel integration time to the whole frame time.
> > - * This value controls the the shutter delay when running with AE
> > + * This value controls the shutter delay when running with AE
> > * disabled. If longer than frame time, it affects the output
> > * frame rate.
> > */
> > --
> > 2.17.1
> >




2022-08-26 12:50:58

by Jules Maselbas

[permalink] [raw]
Subject: Re: [PATCH] media: i2c: Fix repeated word in comments

On Fri, Aug 26, 2022 at 01:23:54PM +0200, Hans Verkuil wrote:
> I'm rejecting these patches in patchwork. All (or almost all) are duplicates.
I was expecting this, I didn't search for exiting patches. Sorry for the
noise.

Thanks
> Regards,
>
> Hans
>
> On 8/26/22 12:24, Jacopo Mondi wrote:
> > Hi Jules
> >
> > thanks, but as reported in patchwork and lore
> > https://patchwork.linuxtv.org/project/linux-media/list/?series=&submitter=&state=*&q=mt9v111&archive=both&delegate=
> > https://lore.kernel.org/all/[email protected]/
> >
> > This is the 4th patch to fix the same repeated word in a comment.
> >
> > As I asked to Jilin, are you submitting this as part of a new
> > contributor program ?
> >
> > Thanks
> > j
> >
> > On Fri, Aug 26, 2022 at 12:00:50PM +0200, Jules Maselbas wrote:
> >> Remove redundant word `the`.
> >>
> >> CC: Jacopo Mondi <[email protected]>
> >> CC: [email protected]
> >> Signed-off-by: Jules Maselbas <[email protected]>
> >> ---
> >> drivers/media/i2c/mt9v111.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/media/i2c/mt9v111.c b/drivers/media/i2c/mt9v111.c
> >> index 2dc4a0f24ce8..7beca0b70b72 100644
> >> --- a/drivers/media/i2c/mt9v111.c
> >> +++ b/drivers/media/i2c/mt9v111.c
> >> @@ -633,7 +633,7 @@ static int mt9v111_hw_config(struct mt9v111_dev *mt9v111)
> >>
> >> /*
> >> * Set pixel integration time to the whole frame time.
> >> - * This value controls the the shutter delay when running with AE
> >> + * This value controls the shutter delay when running with AE
> >> * disabled. If longer than frame time, it affects the output
> >> * frame rate.
> >> */
> >> --
> >> 2.17.1
> >>