2022-07-19 02:30:08

by Thinh Nguyen

[permalink] [raw]
Subject: [PATCH v2 15/25] usb: gadget: f_tcm: Cleanup unused variable

se_cmd is not used anywhere. Remove it.

Signed-off-by: Thinh Nguyen <[email protected]>
---
Changes in v2:
- None

drivers/usb/gadget/function/f_tcm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/function/f_tcm.c b/drivers/usb/gadget/function/f_tcm.c
index 28b560ab44fd..1e7d29f8aecb 100644
--- a/drivers/usb/gadget/function/f_tcm.c
+++ b/drivers/usb/gadget/function/f_tcm.c
@@ -675,7 +675,6 @@ static int uasp_send_read_response(struct usbg_cmd *cmd)
static int uasp_send_write_request(struct usbg_cmd *cmd)
{
struct f_uas *fu = cmd->fu;
- struct se_cmd *se_cmd = &cmd->se_cmd;
struct uas_stream *stream = cmd->stream;
struct sense_iu *iu = &cmd->sense_iu;
int ret;
--
2.28.0


Subject: Re: [PATCH v2 15/25] usb: gadget: f_tcm: Cleanup unused variable

On 2022-07-18 18:27:39 [-0700], Thinh Nguyen wrote:
> se_cmd is not used anywhere. Remove it.

This should folded into the original commit where se_cmd has stopped
been using. I believe it was when target_execute_cmd() has been moved.

> Signed-off-by: Thinh Nguyen <[email protected]>

Sebastian

2022-08-26 18:50:41

by Thinh Nguyen

[permalink] [raw]
Subject: Re: [PATCH v2 15/25] usb: gadget: f_tcm: Cleanup unused variable

On Fri, Aug 26, 2022, Sebastian Andrzej Siewior wrote:
> On 2022-07-18 18:27:39 [-0700], Thinh Nguyen wrote:
> > se_cmd is not used anywhere. Remove it.
>
> This should folded into the original commit where se_cmd has stopped
> been using. I believe it was when target_execute_cmd() has been moved.

Right, I missed that.

Thanks,
Thinh

>
> > Signed-off-by: Thinh Nguyen <[email protected]>
>
> Sebastian