2022-08-29 09:44:20

by Liu Shixin

Subject: [PATCH] mm/thp: simplify has_transparent_hugepage by using IS_BUILTIN

Simplify code of has_transparent_hugepage define by using IS_BUILTIN.

No functional change.

Signed-off-by: Liu Shixin <[email protected]>
---
include/linux/pgtable.h | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
index 73fb1b2af795..a108b60a6962 100644
--- a/include/linux/pgtable.h
+++ b/include/linux/pgtable.h
@@ -1610,11 +1610,7 @@ typedef unsigned int pgtbl_mod_mask;
#endif

#ifndef has_transparent_hugepage
-#ifdef CONFIG_TRANSPARENT_HUGEPAGE
-#define has_transparent_hugepage() 1
-#else
-#define has_transparent_hugepage() 0
-#endif
+#define has_transparent_hugepage() IS_BUILTIN(CONFIG_TRANSPARENT_HUGEPAGE)
#endif

/*
--
2.25.1

2022-08-29 10:40:22

by David Hildenbrand

Subject: Re: [PATCH] mm/thp: simplify has_transparent_hugepage by using IS_BUILTIN

On 29.08.22 11:57, Liu Shixin wrote:
> Simplify code of has_transparent_hugepage define by using IS_BUILTIN.
>
> No functional change.
>
> Signed-off-by: Liu Shixin <[email protected]>
> ---
> include/linux/pgtable.h | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h
> index 73fb1b2af795..a108b60a6962 100644
> --- a/include/linux/pgtable.h
> +++ b/include/linux/pgtable.h
> @@ -1610,11 +1610,7 @@ typedef unsigned int pgtbl_mod_mask;
> #endif
>
> #ifndef has_transparent_hugepage
> -#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> -#define has_transparent_hugepage() 1
> -#else
> -#define has_transparent_hugepage() 0
> -#endif
> +#define has_transparent_hugepage() IS_BUILTIN(CONFIG_TRANSPARENT_HUGEPAGE)
> #endif
>
> /*

Reviewed-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb