2022-08-30 09:51:53

by CGEL

Subject: [PATCH linux-next] media: venus: hfi: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value venus_hfi_create() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/media/platform/qcom/venus/hfi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/media/platform/qcom/venus/hfi.c b/drivers/media/platform/qcom/venus/hfi.c
index 1968f09ad177..e00aedb41d16 100644
--- a/drivers/media/platform/qcom/venus/hfi.c
+++ b/drivers/media/platform/qcom/venus/hfi.c
@@ -569,8 +569,6 @@ irqreturn_t hfi_isr(int irq, void *dev)

int hfi_create(struct venus_core *core, const struct hfi_core_ops *ops)
{
- int ret;
-
if (!ops)
return -EINVAL;

@@ -579,9 +577,8 @@ int hfi_create(struct venus_core *core, const struct hfi_core_ops *ops)
core->state = CORE_UNINIT;
init_completion(&core->done);
pkt_set_version(core->res->hfi_version);
- ret = venus_hfi_create(core);

- return ret;
+ return venus_hfi_create(core);
}

void hfi_destroy(struct venus_core *core)
--
2.25.1

2022-08-30 19:42:07

by Krzysztof Kozlowski

Subject: Re: [PATCH linux-next] media: venus: hfi: Remove the unneeded result variable

On 30/08/2022 11:37, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value venus_hfi_create() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>

Reported-by is used for crediting bug reporters. There is no bug here.
Stop abusing the kernel tags.

Best regards,
Krzysztof