2022-08-30 14:35:56

by CGEL

Subject: [PATCH linux-next] usb: core: remove redundant variables ret

From: Jinpeng Cui <[email protected]>

Rturn value directly from usbdev_do_ioctl() instead of
getting value from redundant variable ret.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jinpeng Cui <[email protected]>
---
drivers/usb/core/devio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
index 837f3e57f580..043d934ead83 100644
--- a/drivers/usb/core/devio.c
+++ b/drivers/usb/core/devio.c
@@ -2802,11 +2802,8 @@ static long usbdev_do_ioctl(struct file *file, unsigned int cmd,
static long usbdev_ioctl(struct file *file, unsigned int cmd,
unsigned long arg)
{
- int ret;
-
- ret = usbdev_do_ioctl(file, cmd, (void __user *)arg);

- return ret;
+ return usbdev_do_ioctl(file, cmd, (void __user *)arg);
}

/* No kernel lock - fine */
--
2.25.1

2022-08-30 16:20:10

by Greg KH

Subject: Re: [PATCH linux-next] usb: core: remove redundant variables ret

On Tue, Aug 30, 2022 at 02:33:18PM +0000, [email protected] wrote:
> From: Jinpeng Cui <[email protected]>
>
> Rturn value directly from usbdev_do_ioctl() instead of
> getting value from redundant variable ret.
>
> Reported-by: Zeal Robot <[email protected]>

As stated before, please read the documentation for how to handle stuff
coming from research tools like this and properly document it in your
changelog text.

Also, why is this being sent from a gmail account? How do we know this
is really from a zte.com.cn address?

thanks,

greg k-h