2022-08-02 11:14:08

by Roger Quadros

[permalink] [raw]
Subject: [PATCH v4 0/2] arm64: dts: ti: k3-am64-main: Add GPMC & ELM nodes

Hi Nishanth,

This series adds GPMC and ELM controller device tree nodes to
AM64 SoC's dtsi file.

Changelog:
v4
- Rebased to v5.19
- use 'ti,am64-elm' compatible for ELM node

v3
- Rebased to v5.17-rc1

v2
- Fix register sizes for GPMC node.
- Disable GPMC and ELM nodes in board files. They will be enabled in
NAND card device tree overlay.

Roger Quadros (2):
arm64: dts: ti: k3-am64-main: Add GPMC memory controller node
arm64: dts: ti: k3-am64-main: Add ELM (Error Location Module) node

arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 28 ++++++++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 8 +++++++
arch/arm64/boot/dts/ti/k3-am642-sk.dts | 8 +++++++
3 files changed, 44 insertions(+)

--
2.17.1



2022-08-02 11:20:46

by Roger Quadros

[permalink] [raw]
Subject: [PATCH v4 2/2] arm64: dts: ti: k3-am64-main: Add ELM (Error Location Module) node

The ELM module is used for GPMC NAND accesses for detecting
and correcting errors during reads due to NAND bitflips errors.

4-, 8-, and 16-bit error-correction levels are supported using
the BCH (Bose-ChaudhurI-Hocquenghem) algorithm.

Signed-off-by: Roger Quadros <[email protected]>
---
arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 9 +++++++++
arch/arm64/boot/dts/ti/k3-am642-evm.dts | 4 ++++
arch/arm64/boot/dts/ti/k3-am642-sk.dts | 4 ++++
3 files changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
index 0059de0aeedf..c1caa7c7c6eb 100644
--- a/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-am64-main.dtsi
@@ -1327,4 +1327,13 @@
gpio-controller;
#gpio-cells = <2>;
};
+
+ elm0: ecc@25010000 {
+ compatible = "ti,am64-elm";
+ reg = <0x00 0x25010000 0x00 0x2000>;
+ interrupts = <GIC_SPI 132 IRQ_TYPE_LEVEL_HIGH>;
+ power-domains = <&k3_pds 54 TI_SCI_PD_EXCLUSIVE>;
+ clocks = <&k3_clks 54 0>;
+ clock-names = "fck";
+ };
};
diff --git a/arch/arm64/boot/dts/ti/k3-am642-evm.dts b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
index 30647fc3eec2..abc0fe61b6b8 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-evm.dts
@@ -680,3 +680,7 @@
&gpmc0 {
status = "disabled";
};
+
+&elm0 {
+ status = "disabled";
+};
diff --git a/arch/arm64/boot/dts/ti/k3-am642-sk.dts b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
index bd9b36b16787..bec1edfeef37 100644
--- a/arch/arm64/boot/dts/ti/k3-am642-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am642-sk.dts
@@ -597,3 +597,7 @@
&gpmc0 {
status = "disabled";
};
+
+&elm0 {
+ status = "disabled";
+};
--
2.17.1


2022-08-30 09:00:39

by Roger Quadros

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] arm64: dts: ti: k3-am64-main: Add GPMC & ELM nodes

Hello Nishant/Vignesh,

On 02/08/2022 13:44, Roger Quadros wrote:
> Hi Nishanth,
>
> This series adds GPMC and ELM controller device tree nodes to
> AM64 SoC's dtsi file.

Gentle ping to pick this series. Thanks!

>
> Changelog:
> v4
> - Rebased to v5.19
> - use 'ti,am64-elm' compatible for ELM node
>
> v3
> - Rebased to v5.17-rc1
>
> v2
> - Fix register sizes for GPMC node.
> - Disable GPMC and ELM nodes in board files. They will be enabled in
> NAND card device tree overlay.
>
> Roger Quadros (2):
> arm64: dts: ti: k3-am64-main: Add GPMC memory controller node
> arm64: dts: ti: k3-am64-main: Add ELM (Error Location Module) node
>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 28 ++++++++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 8 +++++++
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 8 +++++++
> 3 files changed, 44 insertions(+)
>

cheers,
-roger

2022-08-30 22:12:20

by Bryan Brattlof

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] arm64: dts: ti: k3-am64-main: Add GPMC & ELM nodes

Hi Roger!

On August 2, 2022 thus sayeth Roger Quadros:
> Hi Nishanth,
>
> This series adds GPMC and ELM controller device tree nodes to
> AM64 SoC's dtsi file.
>
> Changelog:
> v4
> - Rebased to v5.19
> - use 'ti,am64-elm' compatible for ELM node
>
> v3
> - Rebased to v5.17-rc1
>
> v2
> - Fix register sizes for GPMC node.
> - Disable GPMC and ELM nodes in board files. They will be enabled in
> NAND card device tree overlay.
>
> Roger Quadros (2):
> arm64: dts: ti: k3-am64-main: Add GPMC memory controller node
> arm64: dts: ti: k3-am64-main: Add ELM (Error Location Module) node
>
> arch/arm64/boot/dts/ti/k3-am64-main.dtsi | 28 ++++++++++++++++++++++++
> arch/arm64/boot/dts/ti/k3-am642-evm.dts | 8 +++++++
> arch/arm64/boot/dts/ti/k3-am642-sk.dts | 8 +++++++
> 3 files changed, 44 insertions(+)

Reviewed-by: Bryan Brattlof <[email protected]>

These look good to me :)

~Bryan

2022-09-01 14:36:53

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v4 0/2] arm64: dts: ti: k3-am64-main: Add GPMC & ELM nodes

Hi Roger Quadros,

On Tue, 2 Aug 2022 13:44:54 +0300, Roger Quadros wrote:
> This series adds GPMC and ELM controller device tree nodes to
> AM64 SoC's dtsi file.
>
> Changelog:
> v4
> - Rebased to v5.19
> - use 'ti,am64-elm' compatible for ELM node
>
> [...]

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/2] arm64: dts: ti: k3-am64-main: Add GPMC memory controller node
commit: 5ec06904310da6441097c8f2d6e3fb196f42bca1
[2/2] arm64: dts: ti: k3-am64-main: Add ELM (Error Location Module) node
commit: c920a6caba68196f48f8ee57cc193e396f941011

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh