2022-08-31 01:29:45

by Jilin Yuan

Subject: [PATCH] KVM: fix repeated words in comments

Delete the redundant word 'that'.

Signed-off-by: Jilin Yuan <[email protected]>
---
arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
index e9744b41a226..8e4b42b5f37f 100644
--- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
+++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
@@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
* is valid, it is written to the HPT as if an H_ENTER with the
* exact flag set was done. When the invalid count is non-zero
* in the header written to the stream, the kernel will make
- * sure that that many HPTEs are invalid, and invalidate them
+ * sure that many HPTEs are invalid, and invalidate them
* if not.
*/

--
2.36.1

2022-08-31 03:53:54

by Paul Mackerras

Subject: Re: [PATCH] KVM: fix repeated words in comments

On Wed, Aug 31, 2022 at 08:44:54AM +0800, Jilin Yuan wrote:
> Delete the redundant word 'that'.

Nack, having two "that"s in a row is intentional. It's "make sure
that" (i.e. bring about the situation described in what follows)
"that many HPTEs" (i.e. the number of HPTEs referenced previously)
"are invalid".

> Signed-off-by: Jilin Yuan <[email protected]>
> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index e9744b41a226..8e4b42b5f37f 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> * is valid, it is written to the HPT as if an H_ENTER with the
> * exact flag set was done. When the invalid count is non-zero
> * in the header written to the stream, the kernel will make
> - * sure that that many HPTEs are invalid, and invalidate them
> + * sure that many HPTEs are invalid, and invalidate them
> * if not.
> */

Paul.

2022-08-31 11:15:51

by Christophe Leroy

Subject: Re: [PATCH] KVM: fix repeated words in comments

Le 31/08/2022 à 02:44, Jilin Yuan a écrit :
> Delete the redundant word 'that'.
>
> Signed-off-by: Jilin Yuan <[email protected]>

This change was already proposed and rejected here :
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/[email protected]/

Please study history before submitting such low-value changes.

> ---
> arch/powerpc/kvm/book3s_64_mmu_hv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kvm/book3s_64_mmu_hv.c b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> index e9744b41a226..8e4b42b5f37f 100644
> --- a/arch/powerpc/kvm/book3s_64_mmu_hv.c
> +++ b/arch/powerpc/kvm/book3s_64_mmu_hv.c
> @@ -1601,7 +1601,7 @@ long kvm_vm_ioctl_resize_hpt_commit(struct kvm *kvm,
> * is valid, it is written to the HPT as if an H_ENTER with the
> * exact flag set was done. When the invalid count is non-zero
> * in the header written to the stream, the kernel will make
> - * sure that that many HPTEs are invalid, and invalidate them
> + * sure that many HPTEs are invalid, and invalidate them
> * if not.
> */
>