2022-08-31 04:11:25

by CGEL

Subject: [PATCH linux-next] ACPI: APEI: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value erst_get_record_id_begin() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/acpi/apei/erst.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
index 31b077eedb58..247989060e29 100644
--- a/drivers/acpi/apei/erst.c
+++ b/drivers/acpi/apei/erst.c
@@ -1020,14 +1020,10 @@ static int reader_pos;

static int erst_open_pstore(struct pstore_info *psi)
{
- int rc;
-
if (erst_disable)
return -ENODEV;

- rc = erst_get_record_id_begin(&reader_pos);
-
- return rc;
+ return erst_get_record_id_begin(&reader_pos);
}

static int erst_close_pstore(struct pstore_info *psi)
--
2.25.1

2022-09-10 16:43:43

by Rafael J. Wysocki

Subject: Re: [PATCH linux-next] ACPI: APEI: Remove the unneeded result variable

On Wed, Aug 31, 2022 at 5:31 AM <[email protected]> wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value erst_get_record_id_begin() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---
> drivers/acpi/apei/erst.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
> index 31b077eedb58..247989060e29 100644
> --- a/drivers/acpi/apei/erst.c
> +++ b/drivers/acpi/apei/erst.c
> @@ -1020,14 +1020,10 @@ static int reader_pos;
>
> static int erst_open_pstore(struct pstore_info *psi)
> {
> - int rc;
> -
> if (erst_disable)
> return -ENODEV;
>
> - rc = erst_get_record_id_begin(&reader_pos);
> -
> - return rc;
> + return erst_get_record_id_begin(&reader_pos);
> }
>
> static int erst_close_pstore(struct pstore_info *psi)
> --

Can you please combine this patch with the other analogous one you
sent for APEI?