From: Peng Fan <[email protected]>
V2:
Add binding doc for aonmix/wakeupmix blk ctrl
Update compatible in patch 5 according to binding doc
The lpi2c binding doc has been accepted:
https://lore.kernel.org/all/Yw3hfcQ2JV248GIo@shikoro/
V1:
Add S4MU, BLK CTRL, PMU, LPI2C, LPSPI nodes.
Add GPIO clk entry.
Correct SDHC clk entry
https://patchwork.kernel.org/project/linux-arm-kernel/cover/[email protected]/
Peng Fan (8):
dt-bindings: soc: imx: add binding for i.MX9 syscon
arm64: dts: imx93: correct SDHC clk entry
arm64: dts: imx93: add gpio clk
arm64: dts: imx93: add s4 mu node
arm64: dts: imx93: add blk ctrl node
arm64: dts: imx93: add a55 pmu
arm64: dts: imx93: add lpi2c nodes
arm64: dts: imx93: add lpspi nodes
.../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 ++++
arch/arm64/boot/dts/freescale/imx93.dtsi | 162 +++++++++++++++++-
2 files changed, 193 insertions(+), 6 deletions(-)
create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
--
2.37.1
From: Peng Fan <[email protected]>
Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
Signed-off-by: Peng Fan <[email protected]>
---
.../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
new file mode 100644
index 000000000000..90c5e354f86c
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: NXP i.MX9 Platforms System Controller bindings
+
+maintainers:
+ - Peng Fan <[email protected]>
+
+properties:
+ compatible:
+ oneOf:
+ - items:
+ - enum:
+ - fsl,imx93-aonmix-ns-syscfg
+ - fsl,imx93-wakeupmix-syscfg
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ anomix_ns_gpr: syscon@44210000 {
+ compatible = "fsl,imx93-aonmix-ns-syscfg", "syscon";
+ reg = <0x44210000 0x1000>;
+ };
+
+...
--
2.37.1
From: Peng Fan <[email protected]>
Add the GPIO clk, otherwise GPIO may not work if clk driver disable the
GPIO clk during kernel boot.
Reviewed-by: Jacky Bai <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 431dc239631d..26d5ce4a5f2c 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -295,6 +295,9 @@ gpio2: gpio@43810080 {
interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <2>;
+ clocks = <&clk IMX93_CLK_GPIO2_GATE>,
+ <&clk IMX93_CLK_GPIO2_GATE>;
+ clock-names = "gpio", "port";
gpio-ranges = <&iomuxc 0 32 32>;
};
@@ -306,6 +309,9 @@ gpio3: gpio@43820080 {
interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <2>;
+ clocks = <&clk IMX93_CLK_GPIO3_GATE>,
+ <&clk IMX93_CLK_GPIO3_GATE>;
+ clock-names = "gpio", "port";
gpio-ranges = <&iomuxc 0 64 32>;
};
@@ -317,6 +323,9 @@ gpio4: gpio@43830080 {
interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <2>;
+ clocks = <&clk IMX93_CLK_GPIO4_GATE>,
+ <&clk IMX93_CLK_GPIO4_GATE>;
+ clock-names = "gpio", "port";
gpio-ranges = <&iomuxc 0 96 32>;
};
@@ -328,6 +337,9 @@ gpio1: gpio@47400080 {
interrupts = <GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>;
interrupt-controller;
#interrupt-cells = <2>;
+ clocks = <&clk IMX93_CLK_GPIO1_GATE>,
+ <&clk IMX93_CLK_GPIO1_GATE>;
+ clock-names = "gpio", "port";
gpio-ranges = <&iomuxc 0 0 32>;
};
};
--
2.37.1
From: Peng Fan <[email protected]>
Add i.MX93 BLK CTRL MIX node
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index dd76472ced46..47f98c634365 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -112,6 +112,11 @@ aips1: bus@44000000 {
#size-cells = <1>;
ranges;
+ anomix_ns_gpr: syscon@44210000 {
+ compatible = "fsl,imx93-aonmix-ns-syscfg", "syscon";
+ reg = <0x44210000 0x1000>;
+ };
+
mu1: mailbox@44230000 {
compatible = "fsl,imx93-mu", "fsl,imx8ulp-mu";
reg = <0x44230000 0x10000>;
@@ -174,6 +179,11 @@ aips2: bus@42000000 {
#size-cells = <1>;
ranges;
+ wakeupmix_gpr: syscon@42420000 {
+ compatible = "fsl,imx93-wakeupmix-syscfg", "syscon";
+ reg = <0x42420000 0x1000>;
+ };
+
mu2: mailbox@42440000 {
compatible = "fsl,imx93-mu", "fsl,imx8ulp-mu";
reg = <0x42440000 0x10000>;
--
2.37.1
From: Peng Fan <[email protected]>
Add A55 PMU node for perf usage
Reviewed-by: Ye Li <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 47f98c634365..f007314d8f1e 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -72,6 +72,11 @@ clk_ext1: clock-ext1 {
clock-output-names = "clk_ext1";
};
+ pmu {
+ compatible = "arm,cortex-a55-pmu";
+ interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(2) | IRQ_TYPE_LEVEL_HIGH)>;
+ };
+
psci {
compatible = "arm,psci-1.0";
method = "smc";
--
2.37.1
From: Peng Fan <[email protected]>
Add i.MX93 lpi2c nodes
Signed-off-by: Peng Fan <[email protected]>
---
binding doc accepeted:
https://lore.kernel.org/all/Yw3hfcQ2JV248GIo@shikoro/
arch/arm64/boot/dts/freescale/imx93.dtsi | 89 ++++++++++++++++++++++++
1 file changed, 89 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index f007314d8f1e..58f36897bc5f 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -16,6 +16,14 @@ / {
#size-cells = <2>;
aliases {
+ i2c0 = &lpi2c1;
+ i2c1 = &lpi2c2;
+ i2c2 = &lpi2c3;
+ i2c3 = &lpi2c4;
+ i2c4 = &lpi2c5;
+ i2c5 = &lpi2c6;
+ i2c6 = &lpi2c7;
+ i2c7 = &lpi2c8;
mmc0 = &usdhc1;
mmc1 = &usdhc2;
mmc2 = &usdhc3;
@@ -138,6 +146,26 @@ system_counter: timer@44290000 {
clock-names = "per";
};
+ lpi2c1: i2c@44340000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x44340000 0x10000>;
+ interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C1_GATE>,
+ <&clk IMX93_CLK_BUS_AON>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
+ lpi2c2: i2c@44350000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x44350000 0x10000>;
+ interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C2_GATE>,
+ <&clk IMX93_CLK_BUS_AON>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
lpuart1: serial@44380000 {
compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x44380000 0x1000>;
@@ -197,6 +225,26 @@ mu2: mailbox@42440000 {
status = "disabled";
};
+ lpi2c3: i2c@42530000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x42530000 0x10000>;
+ interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C3_GATE>,
+ <&clk IMX93_CLK_BUS_WAKEUP>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
+ lpi2c4: i2c@42540000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x42540000 0x10000>;
+ interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C4_GATE>,
+ <&clk IMX93_CLK_BUS_WAKEUP>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
lpuart3: serial@42570000 {
compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x42570000 0x1000>;
@@ -250,6 +298,47 @@ lpuart8: serial@426a0000 {
clock-names = "ipg";
status = "disabled";
};
+
+ lpi2c5: i2c@426b0000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x426b0000 0x10000>;
+ interrupts = <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C5_GATE>,
+ <&clk IMX93_CLK_BUS_WAKEUP>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
+ lpi2c6: i2c@426c0000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x426c0000 0x10000>;
+ interrupts = <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C6_GATE>,
+ <&clk IMX93_CLK_BUS_WAKEUP>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
+ lpi2c7: i2c@426d0000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x426d0000 0x10000>;
+ interrupts = <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C7_GATE>,
+ <&clk IMX93_CLK_BUS_WAKEUP>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
+ lpi2c8: i2c@426e0000 {
+ compatible = "fsl,imx93-lpi2c", "fsl,imx7ulp-lpi2c";
+ reg = <0x426e0000 0x10000>;
+ interrupts = <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPI2C8_GATE>,
+ <&clk IMX93_CLK_BUS_WAKEUP>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
};
aips3: bus@42800000 {
--
2.37.1
From: Peng Fan <[email protected]>
Add i.MX93 lpspi nodes
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 58f36897bc5f..281371f6d6b0 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -166,6 +166,30 @@ lpi2c2: i2c@44350000 {
status = "disabled";
};
+ lpspi1: spi@44360000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,imx93-spi", "fsl,imx7ulp-spi";
+ reg = <0x44360000 0x10000>;
+ interrupts = <GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPSPI1_GATE>,
+ <&clk IMX93_CLK_BUS_AON>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
+ lpspi2: spi@44370000 {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ compatible = "fsl,imx93-spi", "fsl,imx7ulp-spi";
+ reg = <0x44370000 0x10000>;
+ interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clk IMX93_CLK_LPSPI2_GATE>,
+ <&clk IMX93_CLK_BUS_AON>;
+ clock-names = "per", "ipg";
+ status = "disabled";
+ };
+
lpuart1: serial@44380000 {
compatible = "fsl,imx93-lpuart", "fsl,imx7ulp-lpuart";
reg = <0x44380000 0x1000>;
--
2.37.1
On 31/08/2022 10:49, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> new file mode 100644
> index 000000000000..90c5e354f86c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
Filename: fsl,imx93-syscon.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: NXP i.MX9 Platforms System Controller bindings
s/bindings//
> +
> +maintainers:
> + - Peng Fan <[email protected]>
> +
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
You miss here select.
> +properties:
> + compatible:
> + oneOf:
Drop oneOf, unless you already have patch adding something more?
> + - items:
> + - enum:
> + - fsl,imx93-aonmix-ns-syscfg
> + - fsl,imx93-wakeupmix-syscfg
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
Best regards,
Krzysztof
From: Peng Fan <[email protected]>
Add s4 mu node for sentinel communication
Reviewed-by: Ye Li <[email protected]>
Reviewed-by: Jacky Bai <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index 26d5ce4a5f2c..dd76472ced46 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -342,5 +342,15 @@ gpio1: gpio@47400080 {
clock-names = "gpio", "port";
gpio-ranges = <&iomuxc 0 0 32>;
};
+
+ s4muap: mailbox@47520000 {
+ compatible = "fsl,imx93-mu-s4";
+ reg = <0x47520000 0x10000>;
+ interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
+ <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-names = "txirq", "rxirq";
+ #mbox-cells = <2>;
+ status = "okay";
+ };
};
};
--
2.37.1
Hi Krzysztof,
> Subject: Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9
> syscon
>
> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
> > From: Peng Fan <[email protected]>
> >
> > Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
> >
> > Signed-off-by: Peng Fan <[email protected]>
> > ---
> > .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> > new file mode 100644
> > index 000000000000..90c5e354f86c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>
> Filename: fsl,imx93-syscon.yaml
There are more i.MX9 SoCs in the coming days, I am thinking to let this yaml
could cover i.MX9[X].
So should I use fsl,imx93-syscon.yaml for now, and rename to
fsl,imx9-syscon.yaml in future?
>
> > @@ -0,0 +1,37 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) %YAML 1.2
> > +---
> > +$id:
> "https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevic
> etree.org%2Fschemas%2Fsoc%2Fimx%2Ffsl%2Cimx9-
> syscon.yaml%23&data=05%7C01%7Cpeng.fan%40nxp.com%7C9dec9a
> aefa1e4c992bd708da8b259c6a%7C686ea1d3bc2b4c6fa92cd99c5c301635%7
> C0%7C0%7C637975290892739302%7CUnknown%7CTWFpbGZsb3d8eyJWIjoi
> MC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C30
> 00%7C%7C%7C&sdata=TvEdbjOMcDosQr5Q82t4aaO7KHJDn5YcSA%2B
> 9XDjj8%2Fc%3D&reserved=0"
> > +$schema:
> "https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevic
> etree.org%2Fmeta-
> schemas%2Fcore.yaml%23&data=05%7C01%7Cpeng.fan%40nxp.com%
> 7C9dec9aaefa1e4c992bd708da8b259c6a%7C686ea1d3bc2b4c6fa92cd99c5c3
> 01635%7C0%7C0%7C637975290892739302%7CUnknown%7CTWFpbGZsb3d
> 8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%
> 3D%7C3000%7C%7C%7C&sdata=0G8y17uvPiZ22xChJCmlTWFX6Tl%2Fq
> G2kXF2bSUXDBaI%3D&reserved=0"
> > +
> > +title: NXP i.MX9 Platforms System Controller bindings
>
> s/bindings//
Drop "bindings" in V3.
>
> > +
> > +maintainers:
> > + - Peng Fan <[email protected]>
> > +
>
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see Documentation/devicetree/bindings/writing-
> schema.rst for instructions).
>
> You miss here select.
There is no error when I ran dt_binding_check
DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
make ARCH=arm64 DT_CHECKER_FLAGS=-m dt_binding_check
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
SCHEMA Documentation/devicetree/bindings/processed-schema.json
DTEX Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dts
DTC Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb
CHECK Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb
>
> > +properties:
> > + compatible:
> > + oneOf:
>
> Drop oneOf, unless you already have patch adding something more?
Ok, drop in v3.
Thanks,
Peng.
>
> > + - items:
> > + - enum:
> > + - fsl,imx93-aonmix-ns-syscfg
> > + - fsl,imx93-wakeupmix-syscfg
> > + - const: syscon
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
>
>
> Best regards,
> Krzysztof
From: Peng Fan <[email protected]>
DUMMY clk only works with clk_ignore_unused and bootloader enables those
clks that required for SDHC work properly.
Correct SDHC clk entry with real clk.
Signed-off-by: Haibo Chen <[email protected]>
Signed-off-by: Peng Fan <[email protected]>
---
arch/arm64/boot/dts/freescale/imx93.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi
index f83a07c7c9b1..431dc239631d 100644
--- a/arch/arm64/boot/dts/freescale/imx93.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93.dtsi
@@ -248,8 +248,8 @@ usdhc1: mmc@42850000 {
compatible = "fsl,imx93-usdhc", "fsl,imx8mm-usdhc";
reg = <0x42850000 0x10000>;
interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk IMX93_CLK_DUMMY>,
- <&clk IMX93_CLK_DUMMY>,
+ clocks = <&clk IMX93_CLK_BUS_WAKEUP>,
+ <&clk IMX93_CLK_WAKEUP_AXI>,
<&clk IMX93_CLK_USDHC1_GATE>;
clock-names = "ipg", "ahb", "per";
bus-width = <8>;
@@ -262,8 +262,8 @@ usdhc2: mmc@42860000 {
compatible = "fsl,imx93-usdhc", "fsl,imx8mm-usdhc";
reg = <0x42860000 0x10000>;
interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk IMX93_CLK_DUMMY>,
- <&clk IMX93_CLK_DUMMY>,
+ clocks = <&clk IMX93_CLK_BUS_WAKEUP>,
+ <&clk IMX93_CLK_WAKEUP_AXI>,
<&clk IMX93_CLK_USDHC2_GATE>;
clock-names = "ipg", "ahb", "per";
bus-width = <4>;
@@ -276,8 +276,8 @@ usdhc3: mmc@428b0000 {
compatible = "fsl,imx93-usdhc", "fsl,imx8mm-usdhc";
reg = <0x428b0000 0x10000>;
interrupts = <GIC_SPI 205 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clk IMX93_CLK_DUMMY>,
- <&clk IMX93_CLK_DUMMY>,
+ clocks = <&clk IMX93_CLK_BUS_WAKEUP>,
+ <&clk IMX93_CLK_WAKEUP_AXI>,
<&clk IMX93_CLK_USDHC3_GATE>;
clock-names = "ipg", "ahb", "per";
bus-width = <4>;
--
2.37.1
On 31/08/2022 10:49, Peng Fan (OSS) wrote:
> From: Peng Fan <[email protected]>
>
> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>
> Signed-off-by: Peng Fan <[email protected]>
> ---
> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> new file mode 100644
> index 000000000000..90c5e354f86c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
One more - drop the quotes both lines above.
Best regards,
Krzysztof
On 31/08/2022 10:57, Peng Fan wrote:
> Hi Krzysztof,
>
>> Subject: Re: [PATCH V2 1/8] dt-bindings: soc: imx: add binding for i.MX9
>> syscon
>>
>> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>>> From: Peng Fan <[email protected]>
>>>
>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>>
>>> Signed-off-by: Peng Fan <[email protected]>
>>> ---
>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
>>> 1 file changed, 37 insertions(+)
>>> create mode 100644
>>> Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>> b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>> new file mode 100644
>>> index 000000000000..90c5e354f86c
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>
>> Filename: fsl,imx93-syscon.yaml
>
> There are more i.MX9 SoCs in the coming days, I am thinking to let this yaml
> could cover i.MX9[X].
If you guarantee that you or someone else will add here more of such,
then it can stay.
(...)
>> Does not look like you tested the bindings. Please run `make
>> dt_binding_check` (see Documentation/devicetree/bindings/writing-
>> schema.rst for instructions).
>>
>> You miss here select.
>
> There is no error when I ran dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
> make ARCH=arm64 DT_CHECKER_FLAGS=-m dt_binding_check
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
> DTEX Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dts
> DTC Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb
> CHECK Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.example.dtb
Eh, you're right, I cannot reproduce the error. Something change in the
schema and custom select seems not needed for this case, but I cannot
identify what exactly changed.
Best regards,
Krzysztof
On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>> From: Peng Fan <[email protected]>
>>
>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>
>> Signed-off-by: Peng Fan <[email protected]>
>> ---
>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
>> 1 file changed, 37 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>> new file mode 100644
>> index 000000000000..90c5e354f86c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>> @@ -0,0 +1,37 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>
> One more - drop the quotes both lines above.
There will be dtbs_check error. I updated schema with:
pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
So it is ok the drop the two quotes above? Is there
any new update in dt-schema that not landed in repo?
Thanks,
Peng.
>
> Best regards,
> Krzysztof
On 31/08/2022 13:08, Peng Fan wrote:
>
>
> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
>> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>>> From: Peng Fan <[email protected]>
>>>
>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>>
>>> Signed-off-by: Peng Fan <[email protected]>
>>> ---
>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
>>> 1 file changed, 37 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>> new file mode 100644
>>> index 000000000000..90c5e354f86c
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>> @@ -0,0 +1,37 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>
>> One more - drop the quotes both lines above.
>
> There will be dtbs_check error. I updated schema with:
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
>
> So it is ok the drop the two quotes above? Is there
> any new update in dt-schema that not landed in repo?
This is something new to me, can you paste the error?
Best regards,
Krzysztof
On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote:
> On 31/08/2022 13:08, Peng Fan wrote:
>>
>>
>> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
>>> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>>>> From: Peng Fan <[email protected]>
>>>>
>>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>>>
>>>> Signed-off-by: Peng Fan <[email protected]>
>>>> ---
>>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
>>>> 1 file changed, 37 insertions(+)
>>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>> new file mode 100644
>>>> index 000000000000..90c5e354f86c
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>> @@ -0,0 +1,37 @@
>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>> +%YAML 1.2
>>>> +---
>>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>
>>> One more - drop the quotes both lines above.
>>
>> There will be dtbs_check error. I updated schema with:
>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
>>
>> So it is ok the drop the two quotes above? Is there
>> any new update in dt-schema that not landed in repo?
>
> This is something new to me, can you paste the error?
I have renamed the file to "fsl,imx93-syscon.yaml"
$DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml
make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check
LINT Documentation/devicetree/bindings
CHKDT Documentation/devicetree/bindings/processed-schema.json
./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error
checking schema file
SCHEMA Documentation/devicetree/bindings/processed-schema.json
Thanks,
Peng.
>
> Best regards,
> Krzysztof
On 31/08/2022 16:41, Peng Fan wrote:
>
>
> On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote:
>> On 31/08/2022 13:08, Peng Fan wrote:
>>>
>>>
>>> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
>>>> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>>>>> From: Peng Fan <[email protected]>
>>>>>
>>>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>>>>
>>>>> Signed-off-by: Peng Fan <[email protected]>
>>>>> ---
>>>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
>>>>> 1 file changed, 37 insertions(+)
>>>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>
>>>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>> new file mode 100644
>>>>> index 000000000000..90c5e354f86c
>>>>> --- /dev/null
>>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>> @@ -0,0 +1,37 @@
>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>> +%YAML 1.2
>>>>> +---
>>>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
>>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>>
>>>> One more - drop the quotes both lines above.
>>>
>>> There will be dtbs_check error. I updated schema with:
>>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
>>>
>>> So it is ok the drop the two quotes above? Is there
>>> any new update in dt-schema that not landed in repo?
>>
>> This is something new to me, can you paste the error?
>
> I have renamed the file to "fsl,imx93-syscon.yaml"
>
> $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml
> make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check
>
> LINT Documentation/devicetree/bindings
> CHKDT Documentation/devicetree/bindings/processed-schema.json
> ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error
> checking schema file
> SCHEMA Documentation/devicetree/bindings/processed-schema.json
Hm, not much of an actual message. Most - or almost all - bindings do
not have quotes, you know...
This is something with your setup because above error is not reproducible.
Best regards,
Krzysztof
On 8/31/2022 9:45 PM, Krzysztof Kozlowski wrote:
> On 31/08/2022 16:41, Peng Fan wrote:
>>
>>
>> On 8/31/2022 8:54 PM, Krzysztof Kozlowski wrote:
>>> On 31/08/2022 13:08, Peng Fan wrote:
>>>>
>>>>
>>>> On 8/31/2022 5:15 PM, Krzysztof Kozlowski wrote:
>>>>> On 31/08/2022 10:49, Peng Fan (OSS) wrote:
>>>>>> From: Peng Fan <[email protected]>
>>>>>>
>>>>>> Add binding doc for i.MX9 blk_ctrl_ns_aonmix and blk_ctrl_wakeupmix
>>>>>>
>>>>>> Signed-off-by: Peng Fan <[email protected]>
>>>>>> ---
>>>>>> .../bindings/soc/imx/fsl,imx9-syscon.yaml | 37 +++++++++++++++++++
>>>>>> 1 file changed, 37 insertions(+)
>>>>>> create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>> new file mode 100644
>>>>>> index 000000000000..90c5e354f86c
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/soc/imx/fsl,imx9-syscon.yaml
>>>>>> @@ -0,0 +1,37 @@
>>>>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>>>>> +%YAML 1.2
>>>>>> +---
>>>>>> +$id: "http://devicetree.org/schemas/soc/imx/fsl,imx9-syscon.yaml#"
>>>>>> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
>>>>>
>>>>> One more - drop the quotes both lines above.
>>>>
>>>> There will be dtbs_check error. I updated schema with:
>>>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@main
>>>>
>>>> So it is ok the drop the two quotes above? Is there
>>>> any new update in dt-schema that not landed in repo?
>>>
>>> This is something new to me, can you paste the error?
>>
>> I have renamed the file to "fsl,imx93-syscon.yaml"
>>
>> $DT_SCHEMA_FILES=Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml
>> make ARCH=arm64 DT_CHECKER_FLAGS=-m dtbs_check
>>
>> LINT Documentation/devicetree/bindings
>> CHKDT Documentation/devicetree/bindings/processed-schema.json
>> ./Documentation/devicetree/bindings/soc/imx/fsl,imx93-syscon.yaml: error
>> checking schema file
>> SCHEMA Documentation/devicetree/bindings/processed-schema.json
>
> Hm, not much of an actual message. Most - or almost all - bindings do
> not have quotes, you know...
>
> This is something with your setup because above error is not reproducible.
I got something wrong in my side, my bad. It passes check now.
Thanks,
Peng.
>
> Best regards,
> Krzysztof