2022-09-02 06:40:13

by Jianqun Xu

Subject: [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names

Add 'clock-names' to the gpio dt node. so the driver could get clocks by
a const char id, this patch names the clock-names as
- 'bus': the apb clock for cpu to access the gpio controller
- 'db': the debounce clock for cpu to set debounce clock rate

Since the old dt nodes may have no clock-names, this patch not make them
as part of 'required properties'.

Signed-off-by: Jianqun Xu <[email protected]>
---
.../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
index affd823c881d..d43d4c71bebf 100644
--- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
+++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
@@ -27,6 +27,12 @@ properties:
- description: APB interface clock source
- description: GPIO debounce reference clock source

+ clock-names:
+ minItems: 1
+ items:
+ - const: bus
+ - const: db
+
gpio-ranges: true

gpio-controller: true
--
2.25.1

2022-09-02 21:31:07

by Rob Herring

Subject: Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names

On Fri, Sep 2, 2022 at 1:04 AM Jianqun Xu <[email protected]> wrote:
>
> Add 'clock-names' to the gpio dt node. so the driver could get clocks by
> a const char id, this patch names the clock-names as
> - 'bus': the apb clock for cpu to access the gpio controller
> - 'db': the debounce clock for cpu to set debounce clock rate
>
> Since the old dt nodes may have no clock-names, this patch not make them
> as part of 'required properties'.
>
> Signed-off-by: Jianqun Xu <[email protected]>
> ---
> .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)

Can Rockchip please address DT binding header licensing:

https://lore.kernel.org/all/[email protected]/
https://lore.kernel.org/all/[email protected]/

2022-09-07 13:15:43

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names

On 02/09/2022 08:04, Jianqun Xu wrote:
> Add 'clock-names' to the gpio dt node. so the driver could get clocks by
> a const char id, this patch names the clock-names as
> - 'bus': the apb clock for cpu to access the gpio controller
> - 'db': the debounce clock for cpu to set debounce clock rate
>
> Since the old dt nodes may have no clock-names, this patch not make them
> as part of 'required properties'.
>
> Signed-off-by: Jianqun Xu <[email protected]>

Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-09-07 14:43:02

by Heiko Stuebner

Subject: Re: [PATCH 1/2] dt-bindings: gpio: rockchip: add clock-names

Am Freitag, 2. September 2022, 08:04:25 CEST schrieb Jianqun Xu:
> Add 'clock-names' to the gpio dt node. so the driver could get clocks by
> a const char id, this patch names the clock-names as
> - 'bus': the apb clock for cpu to access the gpio controller
> - 'db': the debounce clock for cpu to set debounce clock rate
>
> Since the old dt nodes may have no clock-names, this patch not make them
> as part of 'required properties'.
>
> Signed-off-by: Jianqun Xu <[email protected]>

Acked-by: Heiko Stuebner <[email protected]>

> ---
> .../devicetree/bindings/gpio/rockchip,gpio-bank.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> index affd823c881d..d43d4c71bebf 100644
> --- a/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> +++ b/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
> @@ -27,6 +27,12 @@ properties:
> - description: APB interface clock source
> - description: GPIO debounce reference clock source
>
> + clock-names:
> + minItems: 1
> + items:
> + - const: bus
> + - const: db
> +
> gpio-ranges: true
>
> gpio-controller: true
>