2022-09-02 07:53:00

by CGEL

Subject: [PATCH linux-next] xfs: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value xfs_dir_cilookup_result() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
fs/xfs/libxfs/xfs_dir2_sf.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/xfs/libxfs/xfs_dir2_sf.c b/fs/xfs/libxfs/xfs_dir2_sf.c
index 003812fd7d35..8cd37e6e9d38 100644
--- a/fs/xfs/libxfs/xfs_dir2_sf.c
+++ b/fs/xfs/libxfs/xfs_dir2_sf.c
@@ -865,7 +865,6 @@ xfs_dir2_sf_lookup(
struct xfs_inode *dp = args->dp;
struct xfs_mount *mp = dp->i_mount;
int i; /* entry index */
- int error;
xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */
xfs_dir2_sf_hdr_t *sfp; /* shortform structure */
enum xfs_dacmp cmp; /* comparison result */
@@ -929,8 +928,7 @@ xfs_dir2_sf_lookup(
if (!ci_sfep)
return -ENOENT;
/* otherwise process the CI match as required by the caller */
- error = xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen);
- return error;
+ return xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen);
}

/*
--
2.25.1

2022-09-02 20:55:13

by Darrick J. Wong

Subject: Re: [PATCH linux-next] xfs: Remove the unneeded result variable

On Fri, Sep 02, 2022 at 07:32:32AM +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value xfs_dir_cilookup_result() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

LGTM.
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/libxfs/xfs_dir2_sf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_dir2_sf.c b/fs/xfs/libxfs/xfs_dir2_sf.c
> index 003812fd7d35..8cd37e6e9d38 100644
> --- a/fs/xfs/libxfs/xfs_dir2_sf.c
> +++ b/fs/xfs/libxfs/xfs_dir2_sf.c
> @@ -865,7 +865,6 @@ xfs_dir2_sf_lookup(
> struct xfs_inode *dp = args->dp;
> struct xfs_mount *mp = dp->i_mount;
> int i; /* entry index */
> - int error;
> xfs_dir2_sf_entry_t *sfep; /* shortform directory entry */
> xfs_dir2_sf_hdr_t *sfp; /* shortform structure */
> enum xfs_dacmp cmp; /* comparison result */
> @@ -929,8 +928,7 @@ xfs_dir2_sf_lookup(
> if (!ci_sfep)
> return -ENOENT;
> /* otherwise process the CI match as required by the caller */
> - error = xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen);
> - return error;
> + return xfs_dir_cilookup_result(args, ci_sfep->name, ci_sfep->namelen);
> }
>
> /*
> --
> 2.25.1