2022-09-02 09:07:19

by Johan Hovold

Subject: [PATCH] arm64: dts: qcom: sc8280xp: mark USB controllers as wakeup-sources

The primary and secondary USB controllers can be used to wake the system
from suspend so mark them accordingly.

Signed-off-by: Johan Hovold <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 3bbaec97aee9..e441d632c3e8 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -1872,6 +1872,8 @@ usb_0: usb@a6f8800 {
<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
interconnect-names = "usb-ddr", "apps-usb";

+ wakeup-source;
+
status = "disabled";

usb_0_dwc3: usb@a600000 {
@@ -1924,6 +1926,8 @@ usb_1: usb@a8f8800 {
<&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_1 0>;
interconnect-names = "usb-ddr", "apps-usb";

+ wakeup-source;
+
status = "disabled";

usb_1_dwc3: usb@a800000 {
--
2.35.1

2022-09-02 18:25:50

by Steev Klimaszewski

Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: mark USB controllers as wakeup-sources

On 9/2/22 3:16 AM, Johan Hovold wrote:
> The primary and secondary USB controllers can be used to wake the system
> from suspend so mark them accordingly.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 3bbaec97aee9..e441d632c3e8 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1872,6 +1872,8 @@ usb_0: usb@a6f8800 {
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
> interconnect-names = "usb-ddr", "apps-usb";
>
> + wakeup-source;
> +
> status = "disabled";
>
> usb_0_dwc3: usb@a600000 {
> @@ -1924,6 +1926,8 @@ usb_1: usb@a8f8800 {
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_1 0>;
> interconnect-names = "usb-ddr", "apps-usb";
>
> + wakeup-source;
> +
> status = "disabled";
>
> usb_1_dwc3: usb@a800000 {
Tested-by: Steev Klimaszewski <[email protected]> #Lenovo Thinkpad X13s

2022-09-03 13:29:58

by Konrad Dybcio

Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: mark USB controllers as wakeup-sources

On 2.09.2022 10:16, Johan Hovold wrote:
> The primary and secondary USB controllers can be used to wake the system
> from suspend so mark them accordingly.
>
> Signed-off-by: Johan Hovold <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 3bbaec97aee9..e441d632c3e8 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1872,6 +1872,8 @@ usb_0: usb@a6f8800 {
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_0 0>;
> interconnect-names = "usb-ddr", "apps-usb";
>
> + wakeup-source;
> +
> status = "disabled";
>
> usb_0_dwc3: usb@a600000 {
> @@ -1924,6 +1926,8 @@ usb_1: usb@a8f8800 {
> <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_USB3_1 0>;
> interconnect-names = "usb-ddr", "apps-usb";
>
> + wakeup-source;
> +
> status = "disabled";
>
> usb_1_dwc3: usb@a800000 {

2022-09-06 17:04:50

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc8280xp: mark USB controllers as wakeup-sources

On Fri, 2 Sep 2022 10:16:52 +0200, Johan Hovold wrote:
> The primary and secondary USB controllers can be used to wake the system
> from suspend so mark them accordingly.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sc8280xp: mark USB controllers as wakeup-sources
commit: ae240fbffbad6b2f1fc7f2d2f0bb8cf300c489a5

Best regards,
--
Bjorn Andersson <[email protected]>