2022-09-04 05:16:37

by Jagath Jog J

Subject: [PATCH v1 1/2] dt-bindings: rtc: add Maxim max31329 rtc device tree bindings

Document devicetree bindings for the Maxim max31329 Real Time Clock.

Signed-off-by: Jagath Jog J <[email protected]>
---
.../bindings/rtc/maxim,max31329.yaml | 59 +++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 Documentation/devicetree/bindings/rtc/maxim,max31329.yaml

diff --git a/Documentation/devicetree/bindings/rtc/maxim,max31329.yaml b/Documentation/devicetree/bindings/rtc/maxim,max31329.yaml
new file mode 100644
index 000000000000..757f1ac4fdc2
--- /dev/null
+++ b/Documentation/devicetree/bindings/rtc/maxim,max31329.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/rtc/maxim,max31329.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim MAX31329 Real Time Clock
+
+allOf:
+ - $ref: rtc.yaml#
+
+maintainers:
+ - Jagath Jog J <[email protected]>
+
+properties:
+ compatible:
+ const: maxim,max31329
+
+ reg:
+ maxItems: 1
+
+ "#clock-cells":
+ const: 0
+
+ clock-output-names:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ trickle-resistor-ohms:
+ enum:
+ - 3000
+ - 6000
+ - 11000
+
+ start-year: true
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ rtc@68 {
+ compatible = "maxim,max31329";
+ reg = <0x68>;
+ trickle-resistor-ohms = <6000>;
+ #clock-cells = <0>;
+ };
+ };
+...
--
2.17.1

2022-09-05 15:48:37

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 1/2] dt-bindings: rtc: add Maxim max31329 rtc device tree bindings

On 04/09/2022 06:47, Jagath Jog J wrote:
> Document devicetree bindings for the Maxim max31329 Real Time Clock.
>
> Signed-off-by: Jagath Jog J <[email protected]>
> ---
> .../bindings/rtc/maxim,max31329.yaml | 59 +++++++++++++++++++
> 1 file changed, 59 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/rtc/maxim,max31329.yaml
>
> diff --git a/Documentation/devicetree/bindings/rtc/maxim,max31329.yaml b/Documentation/devicetree/bindings/rtc/maxim,max31329.yaml
> new file mode 100644
> index 000000000000..757f1ac4fdc2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/rtc/maxim,max31329.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/rtc/maxim,max31329.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Maxim MAX31329 Real Time Clock
> +
> +allOf:
> + - $ref: rtc.yaml#

If there is going to be resend, put the allOf after maintainers. In any
case:

Reviewed-by: Krzysztof Kozlowski <[email protected]>



Best regards,
Krzysztof