2022-09-05 09:23:12

by CGEL

Subject: [PATCH linux-next] rtc: s35390a: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value s35390a_set_reg() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/rtc/rtc-s35390a.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c
index 81d97b1d3159..b18daaf72b17 100644
--- a/drivers/rtc/rtc-s35390a.c
+++ b/drivers/rtc/rtc-s35390a.c
@@ -211,7 +211,7 @@ static int s35390a_rtc_set_time(struct device *dev, struct rtc_time *tm)
{
struct i2c_client *client = to_i2c_client(dev);
struct s35390a *s35390a = i2c_get_clientdata(client);
- int i, err;
+ int i;
char buf[7], status;

dev_dbg(&client->dev, "%s: tm is secs=%d, mins=%d, hours=%d mday=%d, "
@@ -234,9 +234,7 @@ static int s35390a_rtc_set_time(struct device *dev, struct rtc_time *tm)
for (i = 0; i < 7; ++i)
buf[i] = bitrev8(buf[i]);

- err = s35390a_set_reg(s35390a, S35390A_CMD_TIME1, buf, sizeof(buf));
-
- return err;
+ return s35390a_set_reg(s35390a, S35390A_CMD_TIME1, buf, sizeof(buf));
}

static int s35390a_rtc_read_time(struct device *dev, struct rtc_time *tm)
--
2.25.1

2022-11-14 22:20:47

by Alexandre Belloni

Subject: Re: [PATCH linux-next] rtc: s35390a: Remove the unneeded result variable

On Mon, 5 Sep 2022 09:01:19 +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value s35390a_set_reg() directly instead of storing it in
> another redundant variable.
>
>

Applied, thanks!

[1/1] rtc: s35390a: Remove the unneeded result variable
commit: ba9c9a77035907295c542cf343d3cdd85cdc9a9e

Best regards,

--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com