2022-09-06 07:38:44

by CGEL

Subject: [PATCH linux-next] ocxl: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value opal_npu_spa_clear_cache() directly instead of storing
it in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
arch/powerpc/platforms/powernv/ocxl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/ocxl.c b/arch/powerpc/platforms/powernv/ocxl.c
index 27c936075031..629067781cec 100644
--- a/arch/powerpc/platforms/powernv/ocxl.c
+++ b/arch/powerpc/platforms/powernv/ocxl.c
@@ -478,10 +478,8 @@ EXPORT_SYMBOL_GPL(pnv_ocxl_spa_release);
int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int pe_handle)
{
struct spa_data *data = (struct spa_data *) platform_data;
- int rc;

- rc = opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn, pe_handle);
- return rc;
+ return opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn, pe_handle);
}
EXPORT_SYMBOL_GPL(pnv_ocxl_spa_remove_pe_from_cache);

--
2.25.1

2022-09-07 07:50:27

by Andrew Donnellan

Subject: Re: [PATCH linux-next] ocxl: Remove the unneeded result variable

On Tue, 2022-09-06 at 07:20 +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value opal_npu_spa_clear_cache() directly instead of
> storing
> it in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

Acked-by: Andrew Donnellan <[email protected]>

> ---
>  arch/powerpc/platforms/powernv/ocxl.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/ocxl.c
> b/arch/powerpc/platforms/powernv/ocxl.c
> index 27c936075031..629067781cec 100644
> --- a/arch/powerpc/platforms/powernv/ocxl.c
> +++ b/arch/powerpc/platforms/powernv/ocxl.c
> @@ -478,10 +478,8 @@ EXPORT_SYMBOL_GPL(pnv_ocxl_spa_release);
>  int pnv_ocxl_spa_remove_pe_from_cache(void *platform_data, int
> pe_handle)
>  {
>         struct spa_data *data = (struct spa_data *) platform_data;
> -       int rc;
>  
> -       rc = opal_npu_spa_clear_cache(data->phb_opal_id, data->bdfn,
> pe_handle);
> -       return rc;
> +       return opal_npu_spa_clear_cache(data->phb_opal_id, data-
> >bdfn, pe_handle);
>  }
>  EXPORT_SYMBOL_GPL(pnv_ocxl_spa_remove_pe_from_cache);
>  

--
Andrew Donnellan OzLabs, ADL Canberra
[email protected] IBM Australia Limited

2022-10-04 13:47:23

by Michael Ellerman

Subject: Re: [PATCH linux-next] ocxl: Remove the unneeded result variable

On Tue, 6 Sep 2022 07:20:06 +0000, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Return the value opal_npu_spa_clear_cache() directly instead of storing
> it in another redundant variable.
>
>

Applied to powerpc/next.

[1/1] ocxl: Remove the unneeded result variable
https://git.kernel.org/powerpc/c/5e4952656bca1b5d8c2be36682dc66d844797ad2

cheers