2022-09-06 07:41:03

by CGEL

Subject: [PATCH linux-next] clk: mvebu: armada-37xx-tbg: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value of_clk_add_hw_provider() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
drivers/clk/mvebu/armada-37xx-tbg.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/mvebu/armada-37xx-tbg.c b/drivers/clk/mvebu/armada-37xx-tbg.c
index 585a02e0b330..fc403ad735ad 100644
--- a/drivers/clk/mvebu/armada-37xx-tbg.c
+++ b/drivers/clk/mvebu/armada-37xx-tbg.c
@@ -87,7 +87,7 @@ static int armada_3700_tbg_clock_probe(struct platform_device *pdev)
struct resource *res;
struct clk *parent;
void __iomem *reg;
- int i, ret;
+ int i;

hw_tbg_data = devm_kzalloc(&pdev->dev,
struct_size(hw_tbg_data, hws, NUM_TBG),
@@ -123,9 +123,7 @@ static int armada_3700_tbg_clock_probe(struct platform_device *pdev)
dev_err(dev, "Can't register TBG clock %s\n", name);
}

- ret = of_clk_add_hw_provider(np, of_clk_hw_onecell_get, hw_tbg_data);
-
- return ret;
+ return of_clk_add_hw_provider(np, of_clk_hw_onecell_get, hw_tbg_data);
}

static int armada_3700_tbg_clock_remove(struct platform_device *pdev)
--
2.25.1

2022-10-01 01:00:52

by Stephen Boyd

Subject: Re: [PATCH linux-next] clk: mvebu: armada-37xx-tbg: Remove the unneeded result variable

Quoting [email protected] (2022-09-06 00:23:22)
> From: ye xingchen <[email protected]>
>
> Return the value of_clk_add_hw_provider() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>
> ---

Applied to clk-next