2022-09-07 13:39:26

by Karthikeyan Pasupathi

[permalink] [raw]
Subject: [PATCH v2] ARM: dts: aspeed: yosemit V2: Update for Facebook Yosemite V2 BMC

Removed NIC EEPROM driver IPMB-12 channel and keeping it as
"status ok".

---
--- v2- Updated the title
---

---
--- v1- Initial draft
---

Signed-off-by: Karthikeyan Pasupathi <[email protected]>
---
arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 6 ------
1 file changed, 6 deletions(-)

diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
index 8864e9c312a8..2293f10e94d6 100644
--- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
+++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
@@ -207,12 +207,6 @@

&i2c12 {
status = "okay";
- //MEZZ_FRU
- eeprom@51 {
- compatible = "atmel,24c64";
- reg = <0x51>;
- pagesize = <32>;
- };
};

&pwm_tacho {
--
2.17.1


2022-09-12 22:44:39

by Patrick Williams

[permalink] [raw]
Subject: Re: [PATCH v2] ARM: dts: aspeed: yosemit V2: Update for Facebook Yosemite V2 BMC

On Wed, Sep 07, 2022 at 06:20:35PM +0530, Karthikeyan Pasupathi wrote:

Please improve the title and commit message here. "Update" is
insufficient for a title. There is no description of _why_ in the commit
message.

> Removed NIC EEPROM driver IPMB-12 channel and keeping it as
> "status ok".
>
> ---
> --- v2- Updated the title
> ---
>
> ---
> --- v1- Initial draft
> ---
>
> Signed-off-by: Karthikeyan Pasupathi <[email protected]>
> ---
> arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> index 8864e9c312a8..2293f10e94d6 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-yosemitev2.dts
> @@ -207,12 +207,6 @@
>
> &i2c12 {
> status = "okay";
> - //MEZZ_FRU
> - eeprom@51 {
> - compatible = "atmel,24c64";
> - reg = <0x51>;
> - pagesize = <32>;
> - };
> };
>
> &pwm_tacho {
> --
> 2.17.1
>

--
Patrick Williams


Attachments:
(No filename) (1.10 kB)
signature.asc (849.00 B)
Download all attachments