2022-09-08 11:49:07

by Nick Forrington

[permalink] [raw]
Subject: [PATCH] perf vendor events arm64: Move REMOTE_ACCESS to "memory" category

Move REMOTE_ACCESS event from other.json to memory.json for Neoverse
CPUs. This is consistent with other Arm (Cortex) CPUs.

Signed-off-by: Nick Forrington <[email protected]>
---
.../perf/pmu-events/arch/arm64/arm/cortex-a76-n1/memory.json | 3 +++
.../perf/pmu-events/arch/arm64/arm/cortex-a76-n1/other.json | 5 -----
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json | 3 +++
tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/other.json | 5 -----
tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/memory.json | 3 +++
tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/other.json | 5 -----
6 files changed, 9 insertions(+), 15 deletions(-)
delete mode 100644 tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/other.json
delete mode 100644 tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/other.json
delete mode 100644 tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/other.json

diff --git a/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/memory.json b/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/memory.json
index 20a929e7728d..5bed2514b245 100644
--- a/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/memory.json
+++ b/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/memory.json
@@ -3,6 +3,9 @@
"PublicDescription": "This event counts memory accesses due to load or store instructions. This event counts the sum of MEM_ACCESS_RD and MEM_ACCESS_WR.",
"ArchStdEvent": "MEM_ACCESS"
},
+ {
+ "ArchStdEvent": "REMOTE_ACCESS"
+ },
{
"ArchStdEvent": "MEM_ACCESS_RD"
},
diff --git a/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/other.json b/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/other.json
deleted file mode 100644
index 20d8365756c5..000000000000
--- a/tools/perf/pmu-events/arch/arm64/arm/cortex-a76-n1/other.json
+++ /dev/null
@@ -1,5 +0,0 @@
-[
- {
- "ArchStdEvent": "REMOTE_ACCESS"
- }
-]
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json
index e522113aeb96..7b2b21ac150f 100644
--- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json
+++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/memory.json
@@ -2,6 +2,9 @@
{
"ArchStdEvent": "MEM_ACCESS"
},
+ {
+ "ArchStdEvent": "REMOTE_ACCESS"
+ },
{
"ArchStdEvent": "MEM_ACCESS_RD"
},
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/other.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/other.json
deleted file mode 100644
index 20d8365756c5..000000000000
--- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-n2/other.json
+++ /dev/null
@@ -1,5 +0,0 @@
-[
- {
- "ArchStdEvent": "REMOTE_ACCESS"
- }
-]
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/memory.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/memory.json
index e3d08f1f7c92..5aff6e93c1ad 100644
--- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/memory.json
+++ b/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/memory.json
@@ -2,6 +2,9 @@
{
"ArchStdEvent": "MEM_ACCESS"
},
+ {
+ "ArchStdEvent": "REMOTE_ACCESS"
+ },
{
"ArchStdEvent": "MEM_ACCESS_RD"
},
diff --git a/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/other.json b/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/other.json
deleted file mode 100644
index 20d8365756c5..000000000000
--- a/tools/perf/pmu-events/arch/arm64/arm/neoverse-v1/other.json
+++ /dev/null
@@ -1,5 +0,0 @@
-[
- {
- "ArchStdEvent": "REMOTE_ACCESS"
- }
-]
--
2.25.1


2022-09-08 11:59:04

by John Garry

[permalink] [raw]
Subject: Re: [PATCH] perf vendor events arm64: Move REMOTE_ACCESS to "memory" category

On 08/09/2022 12:25, Nick Forrington wrote:
> Move REMOTE_ACCESS event from other.json to memory.json for Neoverse
> CPUs. This is consistent with other Arm (Cortex) CPUs.
>
> Signed-off-by: Nick Forrington<[email protected]>

Reviewed-by: John Garry <[email protected]>

2022-09-08 16:10:18

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH] perf vendor events arm64: Move REMOTE_ACCESS to "memory" category

Em Thu, Sep 08, 2022 at 12:47:47PM +0100, John Garry escreveu:
> On 08/09/2022 12:25, Nick Forrington wrote:
> > Move REMOTE_ACCESS event from other.json to memory.json for Neoverse
> > CPUs. This is consistent with other Arm (Cortex) CPUs.
> >
> > Signed-off-by: Nick Forrington<[email protected]>
>
> Reviewed-by: John Garry <[email protected]>

Thanks, queued up for 6.1.

- Arnaldo