2022-09-08 14:23:23

by Matthias Brugger

Subject: [PATCH v2] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts

From: Matthias Brugger <[email protected]>

The mt8195-iommu-infra has five banks and one interrupt for each.
Reflect that in the binding.

Signed-off-by: Matthias Brugger <[email protected]>

---

Changes in v2:
- keep wide constrains for minItems and maxItems
- delete unrealted required: - interrupts
- use minItems for mediatek,mt8195-iommu-infra case

.../bindings/iommu/mediatek,iommu.yaml | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
index fee0241b50988..4461dc027d1c4 100644
--- a/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
+++ b/Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml
@@ -91,7 +91,9 @@ properties:
maxItems: 1

interrupts:
- maxItems: 1
+ minItems: 1
+ maxItems: 5
+ description: each bank has one dedicated interrupt

clocks:
items:
@@ -183,6 +185,17 @@ allOf:
required:
- mediatek,infracfg

+ - if:
+ properties:
+ compatible:
+ contains:
+ const: mediatek,mt8195-iommu-infra
+
+ then:
+ properties:
+ interrupts:
+ minItems: 5
+
- if: # The IOMMUs don't have larbs.
not:
properties:
@@ -191,6 +204,9 @@ allOf:
const: mediatek,mt8195-iommu-infra

then:
+ properties:
+ interrupts:
+ maxItems: 1
required:
- mediatek,larbs

--
2.37.3

2022-09-09 08:03:09

by AngeloGioacchino Del Regno

Subject: Re: [PATCH v2] dt-bindings: iommu: mediatek: mt8195: Fix max interrupts

Il 08/09/22 16:15, [email protected] ha scritto:
> From: Matthias Brugger <[email protected]>
>
> The mt8195-iommu-infra has five banks and one interrupt for each.
> Reflect that in the binding.
>
> Signed-off-by: Matthias Brugger <[email protected]>
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>