2022-09-09 07:52:14

by Gaosheng Cui

Subject: [PATCH] xfs: remove xfs_setattr_time() declaration

xfs_setattr_time() has been removed since
commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
attributes"), so remove it.

Signed-off-by: Gaosheng Cui <[email protected]>
---
fs/xfs/xfs_iops.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
index cb5fc68c9ea0..e570dcb5df8d 100644
--- a/fs/xfs/xfs_iops.h
+++ b/fs/xfs/xfs_iops.h
@@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;

extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);

-extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
struct dentry *dentry, struct iattr *vap);

--
2.25.1

2022-09-09 07:56:19

by Carlos Maiolino

Subject: Re: [PATCH] xfs: remove xfs_setattr_time() declaration

On Fri, Sep 09, 2022 at 02:56:54PM +0800, Gaosheng Cui wrote:
> xfs_setattr_time() has been removed since
> commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
> attributes"), so remove it.
>
> Signed-off-by: Gaosheng Cui <[email protected]>

Reviewed-by: Carlos Maiolino <[email protected]>

> ---
> fs/xfs/xfs_iops.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
> index cb5fc68c9ea0..e570dcb5df8d 100644
> --- a/fs/xfs/xfs_iops.h
> +++ b/fs/xfs/xfs_iops.h
> @@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;
>
> extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
>
> -extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
> int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
> struct dentry *dentry, struct iattr *vap);
>
> --
> 2.25.1
>

--
Carlos Maiolino

2022-09-14 16:50:20

by Darrick J. Wong

Subject: Re: [PATCH] xfs: remove xfs_setattr_time() declaration

On Fri, Sep 09, 2022 at 02:56:54PM +0800, Gaosheng Cui wrote:
> xfs_setattr_time() has been removed since
> commit e014f37db1a2 ("xfs: use setattr_copy to set vfs inode
> attributes"), so remove it.
>
> Signed-off-by: Gaosheng Cui <[email protected]>

LGTM
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/xfs_iops.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_iops.h b/fs/xfs/xfs_iops.h
> index cb5fc68c9ea0..e570dcb5df8d 100644
> --- a/fs/xfs/xfs_iops.h
> +++ b/fs/xfs/xfs_iops.h
> @@ -13,7 +13,6 @@ extern const struct file_operations xfs_dir_file_operations;
>
> extern ssize_t xfs_vn_listxattr(struct dentry *, char *data, size_t size);
>
> -extern void xfs_setattr_time(struct xfs_inode *ip, struct iattr *iattr);
> int xfs_vn_setattr_size(struct user_namespace *mnt_userns,
> struct dentry *dentry, struct iattr *vap);
>
> --
> 2.25.1
>