2022-09-09 09:43:34

by Miaohe Lin

Subject: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics()

Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs
are disabled for VM counters"), zone_statistics() is not called with
interrupts disabled. Update the corresponding comment.

Signed-off-by: Miaohe Lin <[email protected]>
---
mm/page_alloc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 2deac2fe3372..c81f06d8a4f5 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt)

/*
* Update NUMA hit/miss statistics
- *
- * Must be called with interrupts disabled.
*/
static inline void zone_statistics(struct zone *preferred_zone, struct zone *z,
long nr_account)
--
2.23.0

2022-09-09 12:00:15

by David Hildenbrand

Subject: Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics()

On 09.09.22 11:24, Miaohe Lin wrote:
> Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs
> are disabled for VM counters"), zone_statistics() is not called with
> interrupts disabled. Update the corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>
> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2deac2fe3372..c81f06d8a4f5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt)
>
> /*
> * Update NUMA hit/miss statistics
> - *
> - * Must be called with interrupts disabled.
> */
> static inline void zone_statistics(struct zone *preferred_zone, struct zone *z,
> long nr_account)


Acked-by: David Hildenbrand <[email protected]>

--
Thanks,

David / dhildenb

2022-09-13 08:39:01

by Anshuman Khandual

Subject: Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics()

On 9/9/22 14:54, Miaohe Lin wrote:
> Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs
> are disabled for VM counters"), zone_statistics() is not called with
> interrupts disabled. Update the corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2deac2fe3372..c81f06d8a4f5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt)
>
> /*
> * Update NUMA hit/miss statistics
> - *
> - * Must be called with interrupts disabled.
> */
> static inline void zone_statistics(struct zone *preferred_zone, struct zone *z,
> long nr_account)

2022-09-15 05:21:38

by Oscar Salvador

Subject: Re: [PATCH 04/16] mm/page_alloc: remove obsolete comment in zone_statistics()

On Fri, Sep 09, 2022 at 05:24:39PM +0800, Miaohe Lin wrote:
> Since commit 43c95bcc51e4 ("mm/page_alloc: reduce duration that IRQs
> are disabled for VM counters"), zone_statistics() is not called with
> interrupts disabled. Update the corresponding comment.
>
> Signed-off-by: Miaohe Lin <[email protected]>

Reviewed-by: Oscar Salvador <[email protected]>

> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 2deac2fe3372..c81f06d8a4f5 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -3671,8 +3671,6 @@ void __putback_isolated_page(struct page *page, unsigned int order, int mt)
>
> /*
> * Update NUMA hit/miss statistics
> - *
> - * Must be called with interrupts disabled.
> */
> static inline void zone_statistics(struct zone *preferred_zone, struct zone *z,
> long nr_account)
> --
> 2.23.0
>

--
Oscar Salvador
SUSE Labs