2022-09-09 15:52:33

by Colin Foster

Subject: [PATCH v1] pinctrl: ocelot: add help and description information to ocelot pinctrl kconfig

Add missed help information and module export name to the Microsemi Ocelot
and Jaguar2 SoC.

Signed-off-by: Colin Foster <[email protected]>
---

v1:
There was a race to get pinctrl-ocelot able to be used as a module. I
lost the race to v6.0-rc1, but still have this reviewed patch with
documentation following me around - I figure I might as well submit
this.

The last patch submission (with reviewed tags) was here:
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/

---
drivers/pinctrl/Kconfig | 5 +++++
drivers/pinctrl/pinctrl-ocelot.c | 2 ++
2 files changed, 7 insertions(+)

diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index d768dcf75cf1..50815f126595 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -324,6 +324,11 @@ config PINCTRL_OCELOT
select GENERIC_PINMUX_FUNCTIONS
select OF_GPIO
select REGMAP_MMIO
+ help
+ Support for the internal GPIO interfaces on Microsemi Ocelot and
+ Jaguar2 SoCs.
+
+ If conpiled as a module, the module name will be pinctrl-ocelot.

config PINCTRL_OXNAS
bool
diff --git a/drivers/pinctrl/pinctrl-ocelot.c b/drivers/pinctrl/pinctrl-ocelot.c
index 340ca2373429..f635743a639d 100644
--- a/drivers/pinctrl/pinctrl-ocelot.c
+++ b/drivers/pinctrl/pinctrl-ocelot.c
@@ -2046,4 +2046,6 @@ static struct platform_driver ocelot_pinctrl_driver = {
.probe = ocelot_pinctrl_probe,
};
module_platform_driver(ocelot_pinctrl_driver);
+
+MODULE_DESCRIPTION("Ocelot Chip Pinctrl Driver");
MODULE_LICENSE("Dual MIT/GPL");
--
2.25.1

2022-09-14 13:21:42

by Linus Walleij

Subject: Re: [PATCH v1] pinctrl: ocelot: add help and description information to ocelot pinctrl kconfig

On Fri, Sep 9, 2022 at 5:38 PM Colin Foster
<[email protected]> wrote:

> Add missed help information and module export name to the Microsemi Ocelot
> and Jaguar2 SoC.
>
> Signed-off-by: Colin Foster <[email protected]>

Patch applied.

Yours,
Linus Walleij