2022-09-09 20:52:44

by Anjelique Melendez

[permalink] [raw]
Subject: [RESEND PATCH v5 0/2] add support for PON GEN3 device

Resent with fixed path for dt-bindings.

Changes from v4:
- Updated commit message for patch 1/2

Changes from v3:
- Addressed Krysztof's comments on patch 1/2
- Added missing minItems/maxItems
- Merged if statments with same constraints together
- Removed description from "reg-names"

Changes from v2:
- Added new "qcom,pmk8350-pon" compatible string as per Krysztof's
advice
- Updated dt logic to use comptaible strings to decide constraints
as per Krysztof's comment
- Added new patch (v3 2/2) to support new compatible string

Changes from v1:
- Updated path which was missing Documentation/devicetree prefix
- Updated CC list

New patch series to separate this patch from applied patches.
Comments from original patch can be found
https://lore.kernel.org/linux-arm-msm/[email protected]/

David Collins (1):
dt-bindings: power: reset: qcom-pon: Add new compatible
"qcom,pmk8350-pon"

Anjelique Melendez (1):
power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string

Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++---
drivers/power/reset/qcom-pon.c | 1 +
2 file changed, 47 insertions(+), 4 deletions(-)

--
2.35.1


2022-09-09 21:04:05

by Anjelique Melendez

[permalink] [raw]
Subject: [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string

Add support for the new "qcom,pmk8350-pon" comptaible string.

Signed-off-by: Anjelique Melendez <[email protected]>
---
drivers/power/reset/qcom-pon.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
index 4a688741a88a..16bc01738be9 100644
--- a/drivers/power/reset/qcom-pon.c
+++ b/drivers/power/reset/qcom-pon.c
@@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = {
{ .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT },
{ .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT },
{ .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT },
+ { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT },
{ }
};
MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);
--
2.35.1

2022-09-10 08:00:27

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string

On 09/09/2022 22:42, Anjelique Melendez wrote:
> Add support for the new "qcom,pmk8350-pon" comptaible string.
>
> Signed-off-by: Anjelique Melendez <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-09-12 04:57:49

by Vinod Koul

[permalink] [raw]
Subject: Re: [RESEND PATCH v5 2/2] power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string

On 09-09-22, 13:42, Anjelique Melendez wrote:
> Add support for the new "qcom,pmk8350-pon" comptaible string.

Reviewed-by: Vinod Koul <[email protected]>

>
> Signed-off-by: Anjelique Melendez <[email protected]>
> ---
> drivers/power/reset/qcom-pon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/reset/qcom-pon.c b/drivers/power/reset/qcom-pon.c
> index 4a688741a88a..16bc01738be9 100644
> --- a/drivers/power/reset/qcom-pon.c
> +++ b/drivers/power/reset/qcom-pon.c
> @@ -82,6 +82,7 @@ static const struct of_device_id pm8916_pon_id_table[] = {
> { .compatible = "qcom,pm8916-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pms405-pon", .data = (void *)GEN1_REASON_SHIFT },
> { .compatible = "qcom,pm8998-pon", .data = (void *)GEN2_REASON_SHIFT },
> + { .compatible = "qcom,pmk8350-pon", .data = (void *)GEN2_REASON_SHIFT },
> { }
> };
> MODULE_DEVICE_TABLE(of, pm8916_pon_id_table);
> --
> 2.35.1

--
~Vinod

2022-09-12 10:47:37

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [RESEND PATCH v5 0/2] add support for PON GEN3 device

Hi,

On Fri, Sep 09, 2022 at 01:42:07PM -0700, Anjelique Melendez wrote:
> Resent with fixed path for dt-bindings.
>
> Changes from v4:
> - Updated commit message for patch 1/2
>
> Changes from v3:
> - Addressed Krysztof's comments on patch 1/2
> - Added missing minItems/maxItems
> - Merged if statments with same constraints together
> - Removed description from "reg-names"
>
> Changes from v2:
> - Added new "qcom,pmk8350-pon" compatible string as per Krysztof's
> advice
> - Updated dt logic to use comptaible strings to decide constraints
> as per Krysztof's comment
> - Added new patch (v3 2/2) to support new compatible string
>
> Changes from v1:
> - Updated path which was missing Documentation/devicetree prefix
> - Updated CC list
>
> New patch series to separate this patch from applied patches.
> Comments from original patch can be found
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> David Collins (1):
> dt-bindings: power: reset: qcom-pon: Add new compatible
> "qcom,pmk8350-pon"
>
> Anjelique Melendez (1):
> power: reset: qcom-pon: add support for qcom,pmk8350-pon compatible string
>
> Documentation/devicetree/bindings/power/reset/qcom,pon.yaml | 50 +++++++++++++++++++++++++++---
> drivers/power/reset/qcom-pon.c | 1 +
> 2 file changed, 47 insertions(+), 4 deletions(-)

Thanks, I queued both patches.

-- Sebastian


Attachments:
(No filename) (1.45 kB)
signature.asc (849.00 B)
Download all attachments