2022-09-10 22:57:10

by Thomas Gleixner

[permalink] [raw]
Subject: [patch RFC 04/29] printk: Remove bogus comment vs. boot consoles

The comment about unregistering boot consoles is just not matching the
reality. Remove it.

Signed-off-by: Thomas Gleixner <[email protected]>
---
kernel/printk/printk.c | 3 ---
1 file changed, 3 deletions(-)

--- a/kernel/printk/printk.c
+++ b/kernel/printk/printk.c
@@ -3213,9 +3213,6 @@ void register_console(struct console *ne
if (bootcon_enabled &&
((newcon->flags & (CON_CONSDEV | CON_BOOT)) == CON_CONSDEV) &&
!keep_bootcon) {
- /* We need to iterate through all boot consoles, to make
- * sure we print everything out, before we unregister them.
- */
for_each_console(con)
if (con->flags & CON_BOOT)
unregister_console(con);


2022-09-14 12:01:48

by Sergey Senozhatsky

[permalink] [raw]
Subject: Re: [patch RFC 04/29] printk: Remove bogus comment vs. boot consoles

On (22/09/11 00:27), Thomas Gleixner wrote:
> Date: Sun, 11 Sep 2022 00:27:38 +0200 (CEST)
> From: Thomas Gleixner <[email protected]>
> To: LKML <[email protected]>
> Cc: John Ogness <[email protected]>, Petr Mladek
> <[email protected]>, Sergey Senozhatsky <[email protected]>, Steven
> Rostedt <[email protected]>, Linus Torvalds
> <[email protected]>, Peter Zijlstra <[email protected]>,
> "Paul E. McKenney" <[email protected]>, Daniel Vetter <[email protected]>,
> Greg Kroah-Hartman <[email protected]>, Helge Deller
> <[email protected]>, Jason Wessel <[email protected]>, Daniel
> Thompson <[email protected]>
> Subject: [patch RFC 04/29] printk: Remove bogus comment vs. boot consoles
> Message-ID: <[email protected]>
>
> The comment about unregistering boot consoles is just not matching the
> reality. Remove it.

Hmm, yeah, we ~CON_ENABLED console that we unregister before we console_unlock().

> Signed-off-by: Thomas Gleixner <[email protected]>

Reviewed-by: Sergey Senozhatsky <[email protected]>