2022-09-10 23:15:38

by Hamza Mahfooz

[permalink] [raw]
Subject: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()

As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
to __drm_debug to discourage use"), we shouldn't explicitly refer to
__drm_debug in this context. So, use drm_debug_enabled() instead.

Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
Signed-off-by: Hamza Mahfooz <[email protected]>
---
drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..875f87c576cb 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg,
struct device *dev = &it6505->client->dev;
int val;

- if (likely(!(__drm_debug & DRM_UT_DRIVER)))
+ if (!drm_debug_enabled(DRM_UT_DRIVER))
return;

val = it6505_read(it6505, reg);
--
2.37.3


2022-09-12 08:23:14

by Jani Nikula

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()

On Sat, 10 Sep 2022, Hamza Mahfooz <[email protected]> wrote:
> As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
> to __drm_debug to discourage use"), we shouldn't explicitly refer to
> __drm_debug in this context. So, use drm_debug_enabled() instead.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Hamza Mahfooz <[email protected]>

Reviewed-by: Jani Nikula <[email protected]>

> ---
> drivers/gpu/drm/bridge/ite-it6505.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
> index 4b673c4792d7..875f87c576cb 100644
> --- a/drivers/gpu/drm/bridge/ite-it6505.c
> +++ b/drivers/gpu/drm/bridge/ite-it6505.c
> @@ -554,7 +554,7 @@ static void it6505_debug_print(struct it6505 *it6505, unsigned int reg,
> struct device *dev = &it6505->client->dev;
> int val;
>
> - if (likely(!(__drm_debug & DRM_UT_DRIVER)))
> + if (!drm_debug_enabled(DRM_UT_DRIVER))
> return;
>
> val = it6505_read(it6505, reg);

--
Jani Nikula, Intel Open Source Graphics Center

Subject: Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()

Il 11/09/22 00:48, Hamza Mahfooz ha scritto:
> As made mention of in commit 9f0ac028410f ("drm/print: rename drm_debug
> to __drm_debug to discourage use"), we shouldn't explicitly refer to
> __drm_debug in this context. So, use drm_debug_enabled() instead.
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Hamza Mahfooz <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2022-09-12 12:01:35

by Robert Foss

[permalink] [raw]
Subject: Re: [PATCH] drm/bridge: it6505: use drm_debug_enabled() in it6505_debug_print()

Applied to drm-misc-next.