2022-09-12 10:26:46

by Zeng Heng

Subject: [PATCH -next 2/2] Kconfig: remove unused function 'menu_get_root_menu'

There is nowhere calling `menu_get_root_menu` function,
so remove it.

Signed-off-by: Zeng Heng <[email protected]>
---
scripts/kconfig/lkc.h | 1 -
scripts/kconfig/menu.c | 5 -----
2 files changed, 6 deletions(-)

diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
index 279d56a44136..a61907686d22 100644
--- a/scripts/kconfig/lkc.h
+++ b/scripts/kconfig/lkc.h
@@ -98,7 +98,6 @@ bool menu_is_empty(struct menu *menu);
bool menu_is_visible(struct menu *menu);
bool menu_has_prompt(struct menu *menu);
const char *menu_get_prompt(struct menu *menu);
-struct menu *menu_get_root_menu(struct menu *menu);
struct menu *menu_get_parent_menu(struct menu *menu);
bool menu_has_help(struct menu *menu);
const char *menu_get_help(struct menu *menu);
diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
index 3d6f7cba8846..62b6313f51c8 100644
--- a/scripts/kconfig/menu.c
+++ b/scripts/kconfig/menu.c
@@ -661,11 +661,6 @@ const char *menu_get_prompt(struct menu *menu)
return NULL;
}

-struct menu *menu_get_root_menu(struct menu *menu)
-{
- return &rootmenu;
-}
-
struct menu *menu_get_parent_menu(struct menu *menu)
{
enum prop_type type;
--
2.25.1

2022-09-13 17:50:44

by Masahiro Yamada

Subject: Re: [PATCH -next 2/2] Kconfig: remove unused function 'menu_get_root_menu'

On Mon, Sep 12, 2022 at 6:41 PM Zeng Heng <[email protected]> wrote:
>
> There is nowhere calling `menu_get_root_menu` function,
> so remove it.
>
> Signed-off-by: Zeng Heng <[email protected]>


Applied to linux-kbuild. Thanks.


> ---
> scripts/kconfig/lkc.h | 1 -
> scripts/kconfig/menu.c | 5 -----
> 2 files changed, 6 deletions(-)
>
> diff --git a/scripts/kconfig/lkc.h b/scripts/kconfig/lkc.h
> index 279d56a44136..a61907686d22 100644
> --- a/scripts/kconfig/lkc.h
> +++ b/scripts/kconfig/lkc.h
> @@ -98,7 +98,6 @@ bool menu_is_empty(struct menu *menu);
> bool menu_is_visible(struct menu *menu);
> bool menu_has_prompt(struct menu *menu);
> const char *menu_get_prompt(struct menu *menu);
> -struct menu *menu_get_root_menu(struct menu *menu);
> struct menu *menu_get_parent_menu(struct menu *menu);
> bool menu_has_help(struct menu *menu);
> const char *menu_get_help(struct menu *menu);
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index 3d6f7cba8846..62b6313f51c8 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -661,11 +661,6 @@ const char *menu_get_prompt(struct menu *menu)
> return NULL;
> }
>
> -struct menu *menu_get_root_menu(struct menu *menu)
> -{
> - return &rootmenu;
> -}
> -
> struct menu *menu_get_parent_menu(struct menu *menu)
> {
> enum prop_type type;
> --
> 2.25.1
>


--
Best Regards
Masahiro Yamada