2022-09-12 10:45:35

by CGEL

Subject: [PATCH linux-next] smack: lsm: remove the unneeded result variable

From: Xu Panda <[email protected]>

Return the value smk_ptrace_rule_check() directly instead of storing it
in another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Xu Panda <[email protected]>
---
security/smack/smack_lsm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
index 16e24a6cdc7c..b6306d71c908 100644
--- a/security/smack/smack_lsm.c
+++ b/security/smack/smack_lsm.c
@@ -497,13 +497,11 @@ static int smack_ptrace_access_check(struct task_struct *ctp, unsigned int mode)
*/
static int smack_ptrace_traceme(struct task_struct *ptp)
{
- int rc;
struct smack_known *skp;

skp = smk_of_task(smack_cred(current_cred()));

- rc = smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
- return rc;
+ return smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
}

/**
--
2.15.2

2022-09-12 17:04:15

by Casey Schaufler

Subject: Re: [PATCH linux-next] smack: lsm: remove the unneeded result variable

On 9/12/2022 3:05 AM, [email protected] wrote:
> From: Xu Panda <[email protected]>
>
> Return the value smk_ptrace_rule_check() directly instead of storing it
> in another redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Xu Panda <[email protected]>

Added to https://github.com/cschaufler/smack-next#next.
Thank you.

> ---
> security/smack/smack_lsm.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/security/smack/smack_lsm.c b/security/smack/smack_lsm.c
> index 16e24a6cdc7c..b6306d71c908 100644
> --- a/security/smack/smack_lsm.c
> +++ b/security/smack/smack_lsm.c
> @@ -497,13 +497,11 @@ static int smack_ptrace_access_check(struct task_struct *ctp, unsigned int mode)
> */
> static int smack_ptrace_traceme(struct task_struct *ptp)
> {
> - int rc;
> struct smack_known *skp;
>
> skp = smk_of_task(smack_cred(current_cred()));
>
> - rc = smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
> - return rc;
> + return smk_ptrace_rule_check(ptp, skp, PTRACE_MODE_ATTACH, __func__);
> }
>
> /**