2022-09-12 12:00:09

by Robert Foss

[permalink] [raw]
Subject: [PATCH v1 1/2] Revert "dt-bindings: Add byteswap order to chrontel ch7033"

As reported by Laurent in response to this commit[1], this functionality should
not be implemented using the devicetree, because of this let's revert this series
for now.

This reverts commit a4be71430c76eca43679e8485085c230afa84460.

[1] https://lore.kernel.org/all/[email protected]/

Signed-off-by: Robert Foss <[email protected]>
---
.../bindings/display/bridge/chrontel,ch7033.yaml | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml b/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml
index 984b90893583..bb6289c7d375 100644
--- a/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/chrontel,ch7033.yaml
@@ -14,19 +14,6 @@ properties:
compatible:
const: chrontel,ch7033

- chrontel,byteswap:
- $ref: /schemas/types.yaml#/definitions/uint8
- enum:
- - 0 # BYTE_SWAP_RGB
- - 1 # BYTE_SWAP_RBG
- - 2 # BYTE_SWAP_GRB
- - 3 # BYTE_SWAP_GBR
- - 4 # BYTE_SWAP_BRG
- - 5 # BYTE_SWAP_BGR
- description: |
- Set the byteswap value of the bridge. This is optional and if not
- set value of BYTE_SWAP_BGR is used.
-
reg:
maxItems: 1
description: I2C address of the device
--
2.34.1


2022-09-13 17:06:31

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH v1 1/2] Revert "dt-bindings: Add byteswap order to chrontel ch7033"

On Mon, Sep 12, 2022 at 01:38:57PM +0200, Robert Foss wrote:
> As reported by Laurent in response to this commit[1], this functionality should
> not be implemented using the devicetree, because of this let's revert this series
> for now.
>
> This reverts commit a4be71430c76eca43679e8485085c230afa84460.
>
> [1] https://lore.kernel.org/all/[email protected]/
>
> Signed-off-by: Robert Foss <[email protected]>
> ---
> .../bindings/display/bridge/chrontel,ch7033.yaml | 13 -------------
> 1 file changed, 13 deletions(-)

In the future, can you wait for a DT maintainer review.

For the revert:

Acked-by: Rob Herring <[email protected]>

Rob