The return value of bcm2835_clock_rate_from_divisor is always unsigned
and also all caller expect this. So fix the declaration accordingly.
Fixes: 41691b8862e2 ("clk: bcm2835: Add support for programming the audio domain clocks")
Signed-off-by: Stefan Wahren <[email protected]>
---
drivers/clk/bcm/clk-bcm2835.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c
index 48a1eb9f2d55..9e9f8b242958 100644
--- a/drivers/clk/bcm/clk-bcm2835.c
+++ b/drivers/clk/bcm/clk-bcm2835.c
@@ -966,9 +966,9 @@ static u32 bcm2835_clock_choose_div(struct clk_hw *hw,
return div;
}
-static long bcm2835_clock_rate_from_divisor(struct bcm2835_clock *clock,
- unsigned long parent_rate,
- u32 div)
+static unsigned long bcm2835_clock_rate_from_divisor(struct bcm2835_clock *clock,
+ unsigned long parent_rate,
+ u32 div)
{
const struct bcm2835_clock_data *data = clock->data;
u64 temp;
--
2.34.1
On 09-04 16:10, Stefan Wahren wrote:
> Date: Sun, 4 Sep 2022 16:10:37 +0200
> From: Stefan Wahren <[email protected]>
> To: Michael Turquette <[email protected]>, Stephen Boyd
> <[email protected]>, Florian Fainelli <[email protected]>, Ray Jui
> <[email protected]>, Scott Branden <[email protected]>, Maxime Ripard
> <[email protected]>
> Cc: [email protected], [email protected],
> [email protected], [email protected], Stefan
> Wahren <[email protected]>
> Subject: [PATCH] clk: bcm2835: fix bcm2835_clock_rate_from_divisor
> declaration
> Message-Id: <[email protected]>
>
> The return value of bcm2835_clock_rate_from_divisor is always unsigned
> and also all caller expect this. So fix the declaration accordingly.
>
> Fixes: 41691b8862e2 ("clk: bcm2835: Add support for programming the audio domain clocks")
> Signed-off-by: Stefan Wahren <[email protected]>
Reviewed-by: Ivan T. Ivanov <[email protected]>
On 9/4/2022 7:10 AM, Stefan Wahren wrote:
> The return value of bcm2835_clock_rate_from_divisor is always unsigned
> and also all caller expect this. So fix the declaration accordingly.
>
> Fixes: 41691b8862e2 ("clk: bcm2835: Add support for programming the audio domain clocks")
> Signed-off-by: Stefan Wahren <[email protected]>
Reviewed-by: Florian Fainelli <[email protected]>
--
Florian
Quoting Stefan Wahren (2022-09-04 07:10:37)
> The return value of bcm2835_clock_rate_from_divisor is always unsigned
> and also all caller expect this. So fix the declaration accordingly.
>
> Fixes: 41691b8862e2 ("clk: bcm2835: Add support for programming the audio domain clocks")
> Signed-off-by: Stefan Wahren <[email protected]>
> ---
Applied to clk-next