2022-09-12 05:54:06

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: Fixes tag needs some work in the mm-stable tree

Hi all,

In commit

831568214883 ("mm: migration: fix the FOLL_GET failure on following huge page")

Fixes tag

Fixes: 4cd614841c06 ("mm: migration: fix possible do_pages_stat_array racing with memory offline")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2022-09-12 13:19:08

by Wang, Haiyue

[permalink] [raw]
Subject: RE: linux-next: Fixes tag needs some work in the mm-stable tree

> -----Original Message-----
> From: Stephen Rothwell <[email protected]>
> Sent: Monday, September 12, 2022 13:46
> To: Andrew Morton <[email protected]>
> Cc: Wang, Haiyue <[email protected]>; Linux Kernel Mailing List <[email protected]>;
> Linux Next Mailing List <[email protected]>
> Subject: linux-next: Fixes tag needs some work in the mm-stable tree
>
> Hi all,
>
> In commit
>
> 831568214883 ("mm: migration: fix the FOLL_GET failure on following huge page")
>
> Fixes tag
>
> Fixes: 4cd614841c06 ("mm: migration: fix possible do_pages_stat_array racing with memory offline")
>

My fault.

It should be "mm/migration", NOT "mm: migration "

Fixes: 4cd614841c06 ("mm/migration: fix possible do_pages_stat_array racing with memory offline")

Should I send new patch ?

> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> --
> Cheers,
> Stephen Rothwell

2022-09-12 19:09:39

by Andrew Morton

[permalink] [raw]
Subject: Re: linux-next: Fixes tag needs some work in the mm-stable tree

On Mon, 12 Sep 2022 13:05:37 +0000 "Wang, Haiyue" <[email protected]> wrote:

> Should I send new patch ?

Nope. I fix things like that.

But in this case I don't think I'll bother. The world won't end.

Thanks, Stephen.