2022-09-13 08:04:41

by Tang Bin

Subject: [PATCH] soc: imx: imx8m-blk-ctrl: Fix wrong check

In the function imx8m_blk_ctrl_probe(),
dev_pm_domain_attach_by_name() may return NULL in some cases,
so IS_ERR() doesn't meet the requirements. Thus fix it.

Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver")
Signed-off-by: Tang Bin <[email protected]>
---
drivers/soc/imx/imx8m-blk-ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c
index ccd0577a7..98a1f2151 100644
--- a/drivers/soc/imx/imx8m-blk-ctrl.c
+++ b/drivers/soc/imx/imx8m-blk-ctrl.c
@@ -235,10 +235,10 @@ static int imx8m_blk_ctrl_probe(struct platform_device *pdev)

domain->power_dev =
dev_pm_domain_attach_by_name(dev, data->gpc_name);
- if (IS_ERR(domain->power_dev)) {
+ if (IS_ERR_OR_NULL(domain->power_dev)) {
dev_err_probe(dev, PTR_ERR(domain->power_dev),
"failed to attach power domain\n");
- ret = PTR_ERR(domain->power_dev);
+ ret = PTR_ERR(domain->power_dev) ? : -ENODATA;
goto cleanup_pds;
}

--
2.20.1.windows.1

2022-09-13 08:14:17

by Russell King (Oracle)

Subject: Re: [PATCH] soc: imx: imx8m-blk-ctrl: Fix wrong check

On Tue, Sep 13, 2022 at 03:21:55PM +0800, Tang Bin wrote:
> In the function imx8m_blk_ctrl_probe(),
> dev_pm_domain_attach_by_name() may return NULL in some cases,
> so IS_ERR() doesn't meet the requirements. Thus fix it.
>
> Fixes: 2684ac05a8c4 ("soc: imx: add i.MX8M blk-ctrl driver")
> Signed-off-by: Tang Bin <[email protected]>

Duplicate of a later patch. See comments on later patch for why this is
potentially wrong.

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!