2022-09-12 15:32:53

by Kaixu Xia

Subject: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

From: Kaixu Xia <[email protected]>

We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.

Signed-off-by: Kaixu Xia <[email protected]>
---
mm/damon/sysfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index 7488e27c87c3..84861c4085a5 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2455,8 +2455,7 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
struct damon_ctx *ctx;
int err;

- if (kdamond->damon_ctx &&
- damon_sysfs_ctx_running(kdamond->damon_ctx))
+ if (damon_sysfs_kdamond_running(kdamond))
return -EBUSY;
if (damon_sysfs_cmd_request.kdamond == kdamond)
return -EBUSY;
--
2.27.0

2022-09-13 16:49:36

by SeongJae Park

Subject: Re: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

Hi Kaixu,

On Mon, 12 Sep 2022 23:11:53 +0800 [email protected] wrote:

> From: Kaixu Xia <[email protected]>
>
> We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
> check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.
>
> Signed-off-by: Kaixu Xia <[email protected]>

Reviewed-by: SeongJae Park <[email protected]>


Thanks,
SJ

> ---
> mm/damon/sysfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
> index 7488e27c87c3..84861c4085a5 100644
> --- a/mm/damon/sysfs.c
> +++ b/mm/damon/sysfs.c
> @@ -2455,8 +2455,7 @@ static int damon_sysfs_turn_damon_on(struct damon_sysfs_kdamond *kdamond)
> struct damon_ctx *ctx;
> int err;
>
> - if (kdamond->damon_ctx &&
> - damon_sysfs_ctx_running(kdamond->damon_ctx))
> + if (damon_sysfs_kdamond_running(kdamond))
> return -EBUSY;
> if (damon_sysfs_cmd_request.kdamond == kdamond)
> return -EBUSY;
> --
> 2.27.0
>

2022-09-14 07:40:07

by Muchun Song

Subject: Re: [PATCH] mm/damon/sysfs: use the wrapper directly to check if the kdamond is running

> On Sep 12, 2022, at 23:11, [email protected] wrote:
>
> From: Kaixu Xia <[email protected]>
>
> We can use the 'damon_sysfs_kdamond_running()' wrapper directly to
> check if the kdamond is running in 'damon_sysfs_turn_damon_on()'.
>
> Signed-off-by: Kaixu Xia <[email protected]>

Reviewed-by: Muchun Song <[email protected]>

Thanks.