2022-09-13 17:52:36

by CGEL

Subject: [PATCH linux-next] net: sched: act_ct: remove redundant variable err

From: Jinpeng Cui <[email protected]>

Return value directly from pskb_trim_rcsum() instead of
getting value from redundant variable err.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Jinpeng Cui <[email protected]>
---
net/sched/act_ct.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
index 4dd3fac42504..9d19710835b0 100644
--- a/net/sched/act_ct.c
+++ b/net/sched/act_ct.c
@@ -696,7 +696,6 @@ static bool tcf_ct_skb_nfct_cached(struct net *net, struct sk_buff *skb,
static int tcf_ct_skb_network_trim(struct sk_buff *skb, int family)
{
unsigned int len;
- int err;

switch (family) {
case NFPROTO_IPV4:
@@ -710,9 +709,7 @@ static int tcf_ct_skb_network_trim(struct sk_buff *skb, int family)
len = skb->len;
}

- err = pskb_trim_rcsum(skb, len);
-
- return err;
+ return pskb_trim_rcsum(skb, len);
}

static u8 tcf_ct_skb_nf_family(struct sk_buff *skb)
--
2.25.1

2022-09-21 12:33:58

by patchwork-bot+netdevbpf

Subject: Re: [PATCH linux-next] net: sched: act_ct: remove redundant variable err

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <[email protected]>:

On Tue, 13 Sep 2022 16:13:26 +0000 you wrote:
> From: Jinpeng Cui <[email protected]>
>
> Return value directly from pskb_trim_rcsum() instead of
> getting value from redundant variable err.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: Jinpeng Cui <[email protected]>
>
> [...]

Here is the summary with links:
- [linux-next] net: sched: act_ct: remove redundant variable err
https://git.kernel.org/netdev/net-next/c/2a566f0148ba

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html