2022-09-13 18:07:34

by Dawei Li

Subject: [PATCH] mm/damon: Creating kmem cache for damon regions by KMEM_CACHE()

Damon regions are dynamic objects which can be created and destroyed
frequently, a dedicated slab cache is created by KMEM_CACHE(), as
suggested by akpm.

Signed-off-by: Dawei Li <[email protected]>
---
mm/damon/core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/mm/damon/core.c b/mm/damon/core.c
index 0b1eb945c68a..20163c3c9aa7 100644
--- a/mm/damon/core.c
+++ b/mm/damon/core.c
@@ -1283,8 +1283,7 @@ bool damon_find_biggest_system_ram(unsigned long *start, unsigned long *end)

static int __init damon_init(void)
{
- damon_region_cache = kmem_cache_create("damon_region_cache", sizeof(struct damon_region),
- 0, 0, NULL);
+ damon_region_cache = KMEM_CACHE(damon_region, 0);
if (unlikely(!damon_region_cache)) {
pr_err("creating damon_region_cache fails\n");
return -ENOMEM;
--
2.25.1

2022-09-13 18:28:46

by SeongJae Park

Subject: Re: [PATCH] mm/damon: Creating kmem cache for damon regions by KMEM_CACHE()

On Wed, 14 Sep 2022 00:21:58 +0800 Dawei Li <[email protected]> wrote:

> Damon regions are dynamic objects which can be created and destroyed
> frequently, a dedicated slab cache is created by KMEM_CACHE(), as
> suggested by akpm.
>
> Signed-off-by: Dawei Li <[email protected]>
> ---
> mm/damon/core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/mm/damon/core.c b/mm/damon/core.c
> index 0b1eb945c68a..20163c3c9aa7 100644
> --- a/mm/damon/core.c
> +++ b/mm/damon/core.c
> @@ -1283,8 +1283,7 @@ bool damon_find_biggest_system_ram(unsigned long *start, unsigned long *end)
>
> static int __init damon_init(void)
> {
> - damon_region_cache = kmem_cache_create("damon_region_cache", sizeof(struct damon_region),
> - 0, 0, NULL);
> + damon_region_cache = KMEM_CACHE(damon_region, 0);

I was about to say about the 80 columns limit, and this fixes it as well.
Thank you, Andrew and Dawei!

> if (unlikely(!damon_region_cache)) {
> pr_err("creating damon_region_cache fails\n");
> return -ENOMEM;
> --
> 2.25.1
>

For this fixup and the initial patch[1],
Reviewed-by: SeongJae Park <[email protected]>

[1] https://lore.kernel.org/damon/TYCP286MB2323DA1894FA55BB9CF90978CA449@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/


Thanks,
SJ