2022-09-15 08:01:43

by Rex-BC Chen (陳柏辰)

[permalink] [raw]
Subject: [PATCH 2/3] drm/mediatek: dp: Remove unused register definitions

Some definitions in mtk_dp_reg.h are not used, so remove these
redundant codes.

Signed-off-by: Bo-Chen Chen <[email protected]>
---
drivers/gpu/drm/mediatek/mtk_dp_reg.h | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_dp_reg.h b/drivers/gpu/drm/mediatek/mtk_dp_reg.h
index 096ad6572a5e..84e38cef03c2 100644
--- a/drivers/gpu/drm/mediatek/mtk_dp_reg.h
+++ b/drivers/gpu/drm/mediatek/mtk_dp_reg.h
@@ -153,8 +153,6 @@
#define CH_STATUS_1_DP_ENC0_P0_MASK GENMASK(15, 0)
#define MTK_DP_ENC0_P0_3094 0x3094
#define CH_STATUS_2_DP_ENC0_P0_MASK GENMASK(7, 0)
-#define MTK_DP_ENC0_P0_30A0 0x30a0
-#define DP_ENC0_30A0_MASK (BIT(7) | BIT(8) | BIT(12))
#define MTK_DP_ENC0_P0_30A4 0x30a4
#define AU_TS_CFG_DP_ENC0_P0_MASK GENMASK(7, 0)
#define MTK_DP_ENC0_P0_30A8 0x30a8
@@ -171,8 +169,6 @@
#define MTK_DP_ENC0_P0_312C 0x312c
#define ASP_HB2_DP_ENC0_P0_MASK GENMASK(7, 0)
#define ASP_HB3_DP_ENC0_P0_MASK GENMASK(15, 8)
-#define MTK_DP_ENC0_P0_3130 0x3130
-#define MTK_DP_ENC0_P0_3138 0x3138
#define MTK_DP_ENC0_P0_3154 0x3154
#define PGEN_HTOTAL_DP_ENC0_P0_MASK GENMASK(13, 0)
#define MTK_DP_ENC0_P0_3158 0x3158
@@ -206,8 +202,6 @@
#define SDP_PACKET_TYPE_DP_ENC1_P0_MASK GENMASK(4, 0)
#define SDP_PACKET_W_DP_ENC1_P0 BIT(5)
#define SDP_PACKET_W_DP_ENC1_P0_MASK BIT(5)
-#define MTK_DP_ENC1_P0_328C 0x328c
-#define VSC_DATA_RDY_VESA_DP_ENC1_P0_MASK BIT(7)
#define MTK_DP_ENC1_P0_3300 0x3300
#define VIDEO_AFIFO_RDY_SEL_DP_ENC1_P0_VAL 2
#define VIDEO_AFIFO_RDY_SEL_DP_ENC1_P0_MASK GENMASK(9, 8)
--
2.18.0


Subject: Re: [PATCH 2/3] drm/mediatek: dp: Remove unused register definitions

Il 15/09/22 09:50, Bo-Chen Chen ha scritto:
> Some definitions in mtk_dp_reg.h are not used, so remove these
> redundant codes.
>
> Signed-off-by: Bo-Chen Chen <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>


2022-09-15 16:47:25

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH 2/3] drm/mediatek: dp: Remove unused register definitions



On 15/09/2022 09:50, Bo-Chen Chen wrote:
> Some definitions in mtk_dp_reg.h are not used, so remove these
> redundant codes.
>
> Signed-off-by: Bo-Chen Chen <[email protected]>

Reviewed-by: Matthias Brugger <[email protected]>

> ---
> drivers/gpu/drm/mediatek/mtk_dp_reg.h | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_dp_reg.h b/drivers/gpu/drm/mediatek/mtk_dp_reg.h
> index 096ad6572a5e..84e38cef03c2 100644
> --- a/drivers/gpu/drm/mediatek/mtk_dp_reg.h
> +++ b/drivers/gpu/drm/mediatek/mtk_dp_reg.h
> @@ -153,8 +153,6 @@
> #define CH_STATUS_1_DP_ENC0_P0_MASK GENMASK(15, 0)
> #define MTK_DP_ENC0_P0_3094 0x3094
> #define CH_STATUS_2_DP_ENC0_P0_MASK GENMASK(7, 0)
> -#define MTK_DP_ENC0_P0_30A0 0x30a0
> -#define DP_ENC0_30A0_MASK (BIT(7) | BIT(8) | BIT(12))
> #define MTK_DP_ENC0_P0_30A4 0x30a4
> #define AU_TS_CFG_DP_ENC0_P0_MASK GENMASK(7, 0)
> #define MTK_DP_ENC0_P0_30A8 0x30a8
> @@ -171,8 +169,6 @@
> #define MTK_DP_ENC0_P0_312C 0x312c
> #define ASP_HB2_DP_ENC0_P0_MASK GENMASK(7, 0)
> #define ASP_HB3_DP_ENC0_P0_MASK GENMASK(15, 8)
> -#define MTK_DP_ENC0_P0_3130 0x3130
> -#define MTK_DP_ENC0_P0_3138 0x3138
> #define MTK_DP_ENC0_P0_3154 0x3154
> #define PGEN_HTOTAL_DP_ENC0_P0_MASK GENMASK(13, 0)
> #define MTK_DP_ENC0_P0_3158 0x3158
> @@ -206,8 +202,6 @@
> #define SDP_PACKET_TYPE_DP_ENC1_P0_MASK GENMASK(4, 0)
> #define SDP_PACKET_W_DP_ENC1_P0 BIT(5)
> #define SDP_PACKET_W_DP_ENC1_P0_MASK BIT(5)
> -#define MTK_DP_ENC1_P0_328C 0x328c
> -#define VSC_DATA_RDY_VESA_DP_ENC1_P0_MASK BIT(7)
> #define MTK_DP_ENC1_P0_3300 0x3300
> #define VIDEO_AFIFO_RDY_SEL_DP_ENC1_P0_VAL 2
> #define VIDEO_AFIFO_RDY_SEL_DP_ENC1_P0_MASK GENMASK(9, 8)