2022-09-15 12:35:13

by Marcus Folkesson

Subject: [PATCH] HID: hid-elan: use default remove for hid device

hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.

Signed-off-by: Marcus Folkesson <[email protected]>
---
drivers/hid/hid-elan.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c
index 8e4a5528e25d..76d93fc48f6a 100644
--- a/drivers/hid/hid-elan.c
+++ b/drivers/hid/hid-elan.c
@@ -507,11 +507,6 @@ static int elan_probe(struct hid_device *hdev, const struct hid_device_id *id)
return ret;
}

-static void elan_remove(struct hid_device *hdev)
-{
- hid_hw_stop(hdev);
-}
-
static const struct hid_device_id elan_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2),
.driver_data = ELAN_HAS_LED },
@@ -529,7 +524,6 @@ static struct hid_driver elan_driver = {
.input_configured = elan_input_configured,
.raw_event = elan_raw_event,
.probe = elan_probe,
- .remove = elan_remove,
};

module_hid_driver(elan_driver);
--
2.37.1

2022-10-14 10:08:29

by Benjamin Tissoires

Subject: Re: [PATCH] HID: hid-elan: use default remove for hid device

On Fri, Oct 14, 2022 at 10:25 AM Marcus Folkesson
<[email protected]> wrote:
>
>
> Den tors 15 sep. 2022 kl 14:28 skrev Marcus Folkesson <[email protected]>:
>>
>> hid_device_remove() will call hid_hw_stop() as default .remove function
>> if no function is specified.
>>
>> Signed-off-by: Marcus Folkesson <[email protected]>
>> ---
>
>
> Ping on this patch and the other similar patches.

Hi Marcus,

Just a quick FYI, we are still in the merge window period, and as such
we can not push anything in linux-next that is not 6.1 material. Given
that I intend to take those in 6.2, I will be able to process those
patches next week at the earliest.

Cheers,
Benjamin