2022-09-15 12:32:54

by Marcus Folkesson

[permalink] [raw]
Subject: [PATCH] HID: hid-alps: use default remove for hid device

hid_device_remove() will call hid_hw_stop() as default .remove function
if no function is specified.

Signed-off-by: Marcus Folkesson <[email protected]>
---
drivers/hid/hid-alps.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c
index 2b986d0dbde4..9abaff6f3afb 100644
--- a/drivers/hid/hid-alps.c
+++ b/drivers/hid/hid-alps.c
@@ -820,11 +820,6 @@ static int alps_probe(struct hid_device *hdev, const struct hid_device_id *id)
return 0;
}

-static void alps_remove(struct hid_device *hdev)
-{
- hid_hw_stop(hdev);
-}
-
static const struct hid_device_id alps_id[] = {
{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY,
USB_VENDOR_ID_ALPS_JP, HID_DEVICE_ID_ALPS_U1_DUAL) },
@@ -840,7 +835,6 @@ static struct hid_driver alps_driver = {
.name = "hid-alps",
.id_table = alps_id,
.probe = alps_probe,
- .remove = alps_remove,
.raw_event = alps_raw_event,
.input_mapping = alps_input_mapping,
.input_configured = alps_input_configured,
--
2.37.1


2022-10-07 08:00:34

by Marcus Folkesson

[permalink] [raw]
Subject: Re: [PATCH] HID: hid-alps: use default remove for hid device

Hi,

On Thu, Sep 15, 2022 at 02:34:38PM +0200, Marcus Folkesson wrote:
> hid_device_remove() will call hid_hw_stop() as default .remove function
> if no function is specified.
>
> Signed-off-by: Marcus Folkesson <[email protected]>

Ping

Best regards,
Marcus Folkesson


Attachments:
(No filename) (292.00 B)
signature.asc (849.00 B)
Download all attachments