2022-09-16 13:55:19

by haoxin

[permalink] [raw]
Subject: [PATCH] mm/damon/sysfs: more simplified code calls damon_target_has_pid()

This patch further simplifies the damon_target_has_pid() call and makes
the damon_sysfs_destroy_targets() look cleaner.

Fixes: 49fb890735ab (mm/damon/sysfs: avoid call damon_target_has_pid() repeatedly)
Signed-off-by: Xin Hao <[email protected]>
Suggested-by: SeongJae Park <[email protected]>
Reviewed-by: SeongJae Park <[email protected]>
---
mm/damon/sysfs.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index dc8dd56d6589..7692c706bcc5 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -2132,10 +2132,7 @@ static int damon_sysfs_set_attrs(struct damon_ctx *ctx,
static void damon_sysfs_destroy_targets(struct damon_ctx *ctx)
{
struct damon_target *t, *next;
- bool has_pid = false;
-
- if (damon_target_has_pid(ctx))
- has_pid = true;
+ bool has_pid = damon_target_has_pid(ctx);

damon_for_each_target_safe(t, next, ctx) {
if (has_pid)
--
2.31.0