2022-09-16 14:26:45

by Yang Yingliang

Subject: [PATCH -next] ALSA: ppc: Switch to use for_each_child_of_node() macro

Use for_each_child_of_node() macro instead of open coding it.
No functional change.

Signed-off-by: Yang Yingliang <[email protected]>
---
sound/ppc/tumbler.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/sound/ppc/tumbler.c b/sound/ppc/tumbler.c
index c65e74d7cd0a..f3f8ad7c3df8 100644
--- a/sound/ppc/tumbler.c
+++ b/sound/ppc/tumbler.c
@@ -1060,8 +1060,7 @@ static struct device_node *find_audio_device(const char *name)
if (! gpiop)
return NULL;

- for (np = of_get_next_child(gpiop, NULL); np;
- np = of_get_next_child(gpiop, np)) {
+ for_each_child_of_node(gpiop, np) {
const char *property = of_get_property(np, "audio-gpio", NULL);
if (property && strcmp(property, name) == 0)
break;
@@ -1080,8 +1079,7 @@ static struct device_node *find_compatible_audio_device(const char *name)
if (!gpiop)
return NULL;

- for (np = of_get_next_child(gpiop, NULL); np;
- np = of_get_next_child(gpiop, np)) {
+ for_each_child_of_node(gpiop, np) {
if (of_device_is_compatible(np, name))
break;
}
--
2.25.1

2022-09-17 08:15:50

by Takashi Iwai

Subject: Re: [PATCH -next] ALSA: ppc: Switch to use for_each_child_of_node() macro

On Fri, 16 Sep 2022 16:11:08 +0200,
Yang Yingliang wrote:
>
> Use for_each_child_of_node() macro instead of open coding it.
> No functional change.
>
> Signed-off-by: Yang Yingliang <[email protected]>

Thanks, applied.


Takashi