2022-09-16 10:56:08

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.10 00/24] 5.10.144-rc1 review

This is the start of the stable review cycle for the 5.10.144 release.
There are 24 patches in this series, all will be posted as a response
to this one. If anyone has any issues with these being applied, please
let me know.

Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.144-rc1.gz
or in the git tree and branch at:
git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <[email protected]>
Linux 5.10.144-rc1

Jarrah Gosbell <[email protected]>
Input: goodix - add compatible string for GT1158

Mathew McBride <[email protected]>
soc: fsl: select FSL_GUTS driver for DPIO

Peter Zijlstra <[email protected]>
x86/ftrace: Use alternative RET encoding

Peter Zijlstra <[email protected]>
x86/ibt,ftrace: Make function-graph play nice

Thadeu Lima de Souza Cascardo <[email protected]>
Revert "x86/ftrace: Use alternative RET encoding"

Jann Horn <[email protected]>
mm: Fix TLB flush for not-first PFNMAP mappings in unmap_region()

Hu Xiaoying <[email protected]>
usb: storage: Add ASUS <0x0b05:0x1932> to IGNORE_UAS

Hans de Goede <[email protected]>
platform/x86: acer-wmi: Acer Aspire One AOD270/Packard Bell Dot keymap fixes

Yu Zhe <[email protected]>
perf/arm_pmu_platform: fix tests for platform_get_irq() failure

Chengming Gui <[email protected]>
drm/amd/amdgpu: skip ucode loading if ucode_size == 0

Maurizio Lombardi <[email protected]>
nvmet-tcp: fix unhandled tcp states in nvmet_tcp_state_change()

Greg Tulli <[email protected]>
Input: iforce - add support for Boeder Force Feedback Wheel

Li Qiong <[email protected]>
ieee802154: cc2520: add rc code in cc2520_tx()

Wei Yongjun <[email protected]>
gpio: mockup: remove gpio debugfs when remove device

Kai-Heng Feng <[email protected]>
tg3: Disable tg3 device on system reboot to avoid triggering AER

Even Xu <[email protected]>
hid: intel-ish-hid: ishtp: Fix ishtp client sending disordered message

Jason Wang <[email protected]>
HID: ishtp-hid-clientHID: ishtp-hid-client: Fix comment typo

Christophe JAILLET <[email protected]>
hwmon: (pmbus) Use dev_err_probe() to filter -EPROBE_DEFER error messages

Rob Clark <[email protected]>
drm/msm/rd: Fix FIFO-full deadlock

Ondrej Jirman <[email protected]>
Input: goodix - add support for GT1158

Brian Norris <[email protected]>
tracefs: Only clobber mode/uid/gid on remount if asked

Lu Baolu <[email protected]>
iommu/vt-d: Correctly calculate sagaw value of IOMMU

Marco Felsch <[email protected]>
ARM: dts: imx6qdl-kontron-samx6i: fix spi-flash compatible

Krzysztof Kozlowski <[email protected]>
ARM: dts: imx: align SPI NOR node name with dtschema


-------------

Diffstat:

Documentation/input/joydev/joystick.rst | 1 +
Makefile | 4 +-
arch/arm/boot/dts/imx28-evk.dts | 2 +-
arch/arm/boot/dts/imx28-m28evk.dts | 2 +-
arch/arm/boot/dts/imx28-sps1.dts | 2 +-
arch/arm/boot/dts/imx6dl-rex-basic.dts | 2 +-
arch/arm/boot/dts/imx6q-ba16.dtsi | 2 +-
arch/arm/boot/dts/imx6q-bx50v3.dtsi | 2 +-
arch/arm/boot/dts/imx6q-cm-fx6.dts | 2 +-
arch/arm/boot/dts/imx6q-dmo-edmqmx6.dts | 2 +-
arch/arm/boot/dts/imx6q-dms-ba16.dts | 2 +-
arch/arm/boot/dts/imx6q-gw5400-a.dts | 2 +-
arch/arm/boot/dts/imx6q-marsboard.dts | 2 +-
arch/arm/boot/dts/imx6q-rex-pro.dts | 2 +-
arch/arm/boot/dts/imx6qdl-aristainetos.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-aristainetos2.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-kontron-samx6i.dtsi | 4 +-
arch/arm/boot/dts/imx6qdl-nit6xlite.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-nitrogen6x.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-sabrelite.dtsi | 2 +-
arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 +-
arch/arm/boot/dts/imx6sl-evk.dts | 2 +-
arch/arm/boot/dts/imx6sx-nitrogen6sx.dts | 2 +-
arch/arm/boot/dts/imx6sx-sdb-reva.dts | 4 +-
arch/arm/boot/dts/imx6sx-sdb.dts | 4 +-
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 +-
arch/arm/boot/dts/imx6ul-kontron-n6310-som.dtsi | 2 +-
arch/arm/boot/dts/imx6ul-kontron-n6311-som.dtsi | 2 +-
.../boot/dts/imx6ul-kontron-n6x1x-som-common.dtsi | 2 +-
arch/arm/boot/dts/imx6ull-kontron-n6411-som.dtsi | 2 +-
arch/x86/kernel/ftrace.c | 7 +--
arch/x86/kernel/ftrace_64.S | 19 ++++--
drivers/gpio/gpio-mockup.c | 9 ++-
drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +-
drivers/gpu/drm/msm/msm_rd.c | 3 +
drivers/hid/intel-ish-hid/ishtp-hid.h | 2 +-
drivers/hid/intel-ish-hid/ishtp/client.c | 68 +++++++++++++---------
drivers/hwmon/pmbus/pmbus_core.c | 9 ++-
drivers/input/joystick/iforce/iforce-main.c | 1 +
drivers/input/touchscreen/goodix.c | 2 +
drivers/iommu/intel/iommu.c | 28 ++++++++-
drivers/net/ethernet/broadcom/tg3.c | 8 ++-
drivers/net/ieee802154/cc2520.c | 1 +
drivers/nvme/target/tcp.c | 3 +
drivers/perf/arm_pmu_platform.c | 2 +-
drivers/platform/x86/acer-wmi.c | 9 ++-
drivers/soc/fsl/Kconfig | 1 +
drivers/usb/storage/unusual_uas.h | 7 +++
fs/tracefs/inode.c | 31 +++++++---
mm/mmap.c | 9 ++-
54 files changed, 196 insertions(+), 100 deletions(-)



2022-09-16 10:56:45

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.10 03/24] iommu/vt-d: Correctly calculate sagaw value of IOMMU

From: Lu Baolu <[email protected]>

[ Upstream commit 53fc7ad6edf210b497230ce74b61b322a202470c ]

The Intel IOMMU driver possibly selects between the first-level and the
second-level translation tables for DMA address translation. However,
the levels of page-table walks for the 4KB base page size are calculated
from the SAGAW field of the capability register, which is only valid for
the second-level page table. This causes the IOMMU driver to stop working
if the hardware (or the emulated IOMMU) advertises only first-level
translation capability and reports the SAGAW field as 0.

This solves the above problem by considering both the first level and the
second level when calculating the supported page table levels.

Fixes: b802d070a52a1 ("iommu/vt-d: Use iova over first level")
Cc: [email protected]
Signed-off-by: Lu Baolu <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Joerg Roedel <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
drivers/iommu/intel/iommu.c | 28 +++++++++++++++++++++++++---
1 file changed, 25 insertions(+), 3 deletions(-)

diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
index 477dde39823c7..93c60712a948e 100644
--- a/drivers/iommu/intel/iommu.c
+++ b/drivers/iommu/intel/iommu.c
@@ -560,14 +560,36 @@ static inline int domain_pfn_supported(struct dmar_domain *domain,
return !(addr_width < BITS_PER_LONG && pfn >> addr_width);
}

+/*
+ * Calculate the Supported Adjusted Guest Address Widths of an IOMMU.
+ * Refer to 11.4.2 of the VT-d spec for the encoding of each bit of
+ * the returned SAGAW.
+ */
+static unsigned long __iommu_calculate_sagaw(struct intel_iommu *iommu)
+{
+ unsigned long fl_sagaw, sl_sagaw;
+
+ fl_sagaw = BIT(2) | (cap_fl1gp_support(iommu->cap) ? BIT(3) : 0);
+ sl_sagaw = cap_sagaw(iommu->cap);
+
+ /* Second level only. */
+ if (!sm_supported(iommu) || !ecap_flts(iommu->ecap))
+ return sl_sagaw;
+
+ /* First level only. */
+ if (!ecap_slts(iommu->ecap))
+ return fl_sagaw;
+
+ return fl_sagaw & sl_sagaw;
+}
+
static int __iommu_calculate_agaw(struct intel_iommu *iommu, int max_gaw)
{
unsigned long sagaw;
int agaw = -1;

- sagaw = cap_sagaw(iommu->cap);
- for (agaw = width_to_agaw(max_gaw);
- agaw >= 0; agaw--) {
+ sagaw = __iommu_calculate_sagaw(iommu);
+ for (agaw = width_to_agaw(max_gaw); agaw >= 0; agaw--) {
if (test_bit(agaw, &sagaw))
break;
}
--
2.35.1



2022-09-16 11:22:45

by Greg Kroah-Hartman

[permalink] [raw]
Subject: [PATCH 5.10 04/24] tracefs: Only clobber mode/uid/gid on remount if asked

From: Brian Norris <[email protected]>

[ Upstream commit 47311db8e8f33011d90dee76b39c8886120cdda4 ]

Users may have explicitly configured their tracefs permissions; we
shouldn't overwrite those just because a second mount appeared.

Only clobber if the options were provided at mount time.

Note: the previous behavior was especially surprising in the presence of
automounted /sys/kernel/debug/tracing/.

Existing behavior:

## Pre-existing status: tracefs is 0755.
# stat -c '%A' /sys/kernel/tracing/
drwxr-xr-x

## (Re)trigger the automount.
# umount /sys/kernel/debug/tracing
# stat -c '%A' /sys/kernel/debug/tracing/.
drwx------

## Unexpected: the automount changed mode for other mount instances.
# stat -c '%A' /sys/kernel/tracing/
drwx------

New behavior (after this change):

## Pre-existing status: tracefs is 0755.
# stat -c '%A' /sys/kernel/tracing/
drwxr-xr-x

## (Re)trigger the automount.
# umount /sys/kernel/debug/tracing
# stat -c '%A' /sys/kernel/debug/tracing/.
drwxr-xr-x

## Expected: the automount does not change other mount instances.
# stat -c '%A' /sys/kernel/tracing/
drwxr-xr-x

Link: https://lkml.kernel.org/r/20220826174353.2.Iab6e5ea57963d6deca5311b27fb7226790d44406@changeid

Cc: [email protected]
Fixes: 4282d60689d4f ("tracefs: Add new tracefs file system")
Signed-off-by: Brian Norris <[email protected]>
Signed-off-by: Steven Rostedt (Google) <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
---
fs/tracefs/inode.c | 31 +++++++++++++++++++++++--------
1 file changed, 23 insertions(+), 8 deletions(-)

diff --git a/fs/tracefs/inode.c b/fs/tracefs/inode.c
index 8b7315c22f0d1..4b70571368526 100644
--- a/fs/tracefs/inode.c
+++ b/fs/tracefs/inode.c
@@ -139,6 +139,8 @@ struct tracefs_mount_opts {
kuid_t uid;
kgid_t gid;
umode_t mode;
+ /* Opt_* bitfield. */
+ unsigned int opts;
};

enum {
@@ -239,6 +241,7 @@ static int tracefs_parse_options(char *data, struct tracefs_mount_opts *opts)
kgid_t gid;
char *p;

+ opts->opts = 0;
opts->mode = TRACEFS_DEFAULT_MODE;

while ((p = strsep(&data, ",")) != NULL) {
@@ -273,24 +276,36 @@ static int tracefs_parse_options(char *data, struct tracefs_mount_opts *opts)
* but traditionally tracefs has ignored all mount options
*/
}
+
+ opts->opts |= BIT(token);
}

return 0;
}

-static int tracefs_apply_options(struct super_block *sb)
+static int tracefs_apply_options(struct super_block *sb, bool remount)
{
struct tracefs_fs_info *fsi = sb->s_fs_info;
struct inode *inode = sb->s_root->d_inode;
struct tracefs_mount_opts *opts = &fsi->mount_opts;

- inode->i_mode &= ~S_IALLUGO;
- inode->i_mode |= opts->mode;
+ /*
+ * On remount, only reset mode/uid/gid if they were provided as mount
+ * options.
+ */
+
+ if (!remount || opts->opts & BIT(Opt_mode)) {
+ inode->i_mode &= ~S_IALLUGO;
+ inode->i_mode |= opts->mode;
+ }

- inode->i_uid = opts->uid;
+ if (!remount || opts->opts & BIT(Opt_uid))
+ inode->i_uid = opts->uid;

- /* Set all the group ids to the mount option */
- set_gid(sb->s_root, opts->gid);
+ if (!remount || opts->opts & BIT(Opt_gid)) {
+ /* Set all the group ids to the mount option */
+ set_gid(sb->s_root, opts->gid);
+ }

return 0;
}
@@ -305,7 +320,7 @@ static int tracefs_remount(struct super_block *sb, int *flags, char *data)
if (err)
goto fail;

- tracefs_apply_options(sb);
+ tracefs_apply_options(sb, true);

fail:
return err;
@@ -357,7 +372,7 @@ static int trace_fill_super(struct super_block *sb, void *data, int silent)

sb->s_op = &tracefs_super_operations;

- tracefs_apply_options(sb);
+ tracefs_apply_options(sb, false);

return 0;

--
2.35.1



2022-09-16 14:27:36

by Pavel Machek

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

Hi!

> This is the start of the stable review cycle for the 5.10.144 release.
> There are 24 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.

CIP testing did not find any problems here:

https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y

Tested-by: Pavel Machek (CIP) <[email protected]>

Best regards,
Pavel

--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (663.00 B)
signature.asc (201.00 B)
Download all attachments

2022-09-16 21:59:07

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

On Fri, Sep 16, 2022 at 12:08:25PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.144 release.
> There are 24 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000.
> Anything received after that time might be too late.
>

Build results:
total: 163 pass: 163 fail: 0
Qemu test results:
total: 475 pass: 475 fail: 0

Tested-by: Guenter Roeck <[email protected]>

Guenter

2022-09-17 14:57:01

by Sudip Mukherjee

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

Hi Greg,

On Fri, Sep 16, 2022 at 12:08:25PM +0200, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.144 release.
> There are 24 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000.
> Anything received after that time might be too late.

Build test (gcc version 11.3.1 20220819):
mips: 63 configs -> no failure
arm: 104 configs -> no failure
arm64: 3 configs -> no failure
x86_64: 4 configs -> no failure
alpha allmodconfig -> no failure
powerpc allmodconfig -> no failure
riscv allmodconfig -> no failure
s390 allmodconfig -> no failure
xtensa allmodconfig -> no failure

Boot test:
x86_64: Booted on my test laptop. No regression.
x86_64: Booted on qemu. No regression. [1]
arm64: Booted on rpi4b (4GB model). No regression. [2]

[1]. https://openqa.qa.codethink.co.uk/tests/1844
[2]. https://openqa.qa.codethink.co.uk/tests/1847


Tested-by: Sudip Mukherjee <[email protected]>

--
Regards
Sudip

2022-09-17 16:32:01

by Naresh Kamboju

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

On Fri, 16 Sept 2022 at 15:41, Greg Kroah-Hartman
<[email protected]> wrote:
>
> This is the start of the stable review cycle for the 5.10.144 release.
> There are 24 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.144-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

Results from Linaro's test farm.
Regressions on x86_64 while running libgpiod tests.

Regressions on x86_64 while running libgpiod tests.
This reported regression also noticed on mainline, stable-rc 5.19,
stable-rc 5.15 and stable-rc 5.10 branches

I have not bisected this reported crash yet.

Reported-by: Linux Kernel Functional Testing <[email protected]>

+ cd ./automated/linux/gpiod
+ ./gpiod.sh /opt/libgpiod/bin/
[INFO] libgpiod test suite
[INFO] 117 tests registered
[INFO] checking the linux kernel version
[INFO] kernel release is v5.10.144 - ok to run tests
[INFO] using gpio-tools from '/usr/bin'
[ 10.900672] BUG: kernel NULL pointer dereference, address: 00000000000000a0
[ 10.901452] #PF: supervisor write access in kernel mode
[ 10.901452] #PF: error_code(0x0002) - not-present page
[ 10.901452] PGD 108545067 P4D 108545067 PUD 108544067 PMD 0
[ 10.901452] Oops: 0002 [#1] SMP NOPTI
[ 10.901452] CPU: 1 PID: 479 Comm: gpiod-test Not tainted 5.10.144-rc1 #1
[ 10.901452] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
BIOS 1.12.0-1 04/01/2014
[ 10.901452] RIP: 0010:down_write+0x1a/0x60
[ 10.901452] Code: 00 31 c0 eb dd e8 76 9e ff ff cc cc cc cc cc cc
0f 1f 44 00 00 55 48 89 e5 41 54 49 89 fc e8 4d d9 ff ff 31 c0 ba 01
00 00 00 <f0> 49 0f b1 14 24 75 18 65 48 8b 04 25 80 ad 01 00 49 89 44
24 08
[ 10.901452] RSP: 0018:ffffaf1f005abd08 EFLAGS: 00010246
[ 10.901452] RAX: 0000000000000000 RBX: ffffa38c448f6a80 RCX: ffffff8100000000
[ 10.901452] RDX: 0000000000000001 RSI: ffffff8100000000 RDI: 00000000000000a0
[ 10.901452] RBP: ffffaf1f005abd10 R08: 0000000000000286 R09: ffffa38c448f6ad8
[ 10.901452] R10: 000000000000003e R11: ffffa38c44a4dea8 R12: 00000000000000a0
[ 10.901452] R13: ffffaf1f005abdb0 R14: 00000000000000a0 R15: ffffa38c44530c40
[ 10.901452] FS: 00007fbd204f7740(0000) GS:ffffa38c7bc80000(0000)
knlGS:0000000000000000
[ 10.901452] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 10.901452] CR2: 00000000000000a0 CR3: 0000000108490000 CR4: 00000000003506e0
[ 10.901452] Call Trace:
[ 10.901452] simple_recursive_removal+0x55/0x2b0
[ 10.901452] ? debugfs_rename+0x2e0/0x2e0
[ 10.901452] debugfs_remove+0x45/0x70
[ 10.901452] gpio_mockup_debugfs_cleanup+0x15/0x20 [gpio_mockup]
[ 10.901452] devm_action_release+0x15/0x20
[ 10.901452] release_nodes+0x1bd/0x210
[ 10.901452] devres_release_all+0x3f/0x60
[ 10.901452] __device_release_driver+0x195/0x260
[ 10.901452] driver_detach+0xce/0x110
[ 10.901452] bus_remove_driver+0x5c/0xe0
[ 10.901452] driver_unregister+0x31/0x60
[ 10.901452] platform_driver_unregister+0x12/0x20
[ 10.901452] gpio_mockup_exit+0x1c/0x4c4 [gpio_mockup]
[ 10.901452] __do_sys_delete_module+0x1b2/0x290
[ 10.901452] ? syscall_trace_enter.constprop.0+0x13c/0x1b0
[ 10.901452] __x64_sys_delete_module+0x18/0x20
[ 10.901452] do_syscall_64+0x38/0x50
[ 10.901452] entry_SYSCALL_64_after_hwframe+0x61/0xc6
[ 10.901452] RIP: 0033:0x7fbd2069c95b
[ 10.901452] Code: 73 01 c3 48 8b 0d c5 34 0e 00 f7 d8 64 89 01 48
83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00
00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 95 34 0e 00 f7 d8 64 89
01 48
[ 10.901452] RSP: 002b:00007ffdfa2d9348 EFLAGS: 00000206 ORIG_RAX:
00000000000000b0
[ 10.901452] RAX: ffffffffffffffda RBX: 00000000022af370 RCX: 00007fbd2069c95b
[ 10.939140] RDX: 00000000022ad8b7 RSI: 0000000000000800 RDI: 00000000022af938
[ 10.939140] RBP: 00000000022af370 R08: 0000000000000007 R09: 00000000022b75c0
[ 10.939140] R10: 00007fbd205a6b88 R11: 0000000000000206 R12: 00000000022af420
[ 10.939140] R13: 00007fbd20743b00 R14: 0000000000418df8 R15: 00007fbd207dc000
[ 10.939140] Modules linked in: gpio_mockup(-)
[ 10.939140] CR2: 00000000000000a0
[ 10.939140] ---[ end trace e891f796dd2f311d ]---
[ 10.939140] RIP: 0010:down_write+0x1a/0x60
[ 10.939140] Code: 00 31 c0 eb dd e8 76 9e ff ff cc cc cc cc cc cc
0f 1f 44 00 00 55 48 89 e5 41 54 49 89 fc e8 4d d9 ff ff 31 c0 ba 01
00 00 00 <f0> 49 0f b1 14 24 75 18 65 48 8b 04 25 80 ad 01 00 49 89 44
24 08
[ 10.939140] RSP: 0018:ffffaf1f005abd08 EFLAGS: 00010246
[ 10.939140] RAX: 0000000000000000 RBX: ffffa38c448f6a80 RCX: ffffff8100000000
[ 10.939140] RDX: 0000000000000001 RSI: ffffff8100000000 RDI: 00000000000000a0
[ 10.939140] RBP: ffffaf1f005abd10 R08: 0000000000000286 R09: ffffa38c448f6ad8
[ 10.939140] R10: 000000000000003e R11: ffffa38c44a4dea8 R12: 00000000000000a0
[ 10.939140] R13: ffffaf1f005abdb0 R14: 00000000000000a0 R15: ffffa38c44530c40
[ 10.939140] FS: 00007fbd204f7740(0000) GS:ffffa38c7bc80000(0000)
knlGS:0000000000000000
[ 10.939140] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 10.939140] CR2: 00000000000000a0 CR3: 0000000108490000 CR4: 00000000003506e0
+ ../../utils/send-to-lava.sh result.txt

https://lkft.validation.linaro.org/scheduler/job/5547188#L992
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.143-25-g02c4837d98bf/testrun/11952159/suite/log-parser-test/tests/
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.143-25-g02c4837d98bf/testrun/11954093/suite/log-parser-test/tests/


## Build
* kernel: 5.10.144-rc1
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.10.y
* git commit: 02c4837d98bf509b70afb8368175c489a5ba7b4a
* git describe: v5.10.143-25-g02c4837d98bf
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.143-25-g02c4837d98bf

## Test Regressions (compared to v5.10.143)
- Kernel BUG while running libgpiod on x86_64.

## No metric Regressions (compared to v5.10.143)

## No test Fixes (compared to v5.10.143)

## No metric Fixes (compared to v5.10.143)


## Test result summary
total: 102380, pass: 89955, fail: 750, skip: 11365, xfail: 310

## Build Summary
* arc: 10 total, 10 passed, 0 failed
* arm: 333 total, 333 passed, 0 failed
* arm64: 65 total, 63 passed, 2 failed
* i386: 56 total, 53 passed, 3 failed
* mips: 56 total, 56 passed, 0 failed
* parisc: 12 total, 12 passed, 0 failed
* powerpc: 60 total, 55 passed, 5 failed
* riscv: 27 total, 27 passed, 0 failed
* s390: 24 total, 24 passed, 0 failed
* sh: 24 total, 24 passed, 0 failed
* sparc: 12 total, 12 passed, 0 failed
* x86_64: 59 total, 56 passed, 3 failed

## Test suites summary
* fwts
* igt-gpu-tools
* kunit
* kvm-unit-tests
* libhugetlbfs
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-open-posix-tests
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-syscalls
* ltp-tracing
* network-basic-tests
* packetdrill
* rcutorture
* v4l2-compliance
* vdso

--
Linaro LKFT
https://lkft.linaro.org

2022-09-19 00:03:21

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/24] 5.10.144-rc1 review



On 9/16/2022 3:08 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.144 release.
> There are 24 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.144-rc1.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h

On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:

Tested-by: Florian Fainelli <[email protected]>
--
Florian

2022-09-19 10:52:45

by Pavel Machek

[permalink] [raw]
Subject: 5.10.144 got more patches? was Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

Hi!

> > This is the start of the stable review cycle for the 5.10.144 release.
> > There are 24 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
>
> CIP testing did not find any problems here:
>
> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
>
> Tested-by: Pavel Machek (CIP) <[email protected]>

And now I'm confused.

5.10.144-rc1 was announced / tested, but now there's buch more patches
in the queue, starting with

|9843b839a 174974 .: 5.10| drm/msm/rd: Fix FIFO-full deadlock
|518b67da4 174974 .: 4.19| drm/msm/rd: Fix FIFO-full deadlock
|88eba3686 174974 .: 4.9| drm/msm/rd: Fix FIFO-full deadlock

Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


Attachments:
(No filename) (946.00 B)
signature.asc (201.00 B)
Download all attachments

2022-09-19 12:55:54

by Guenter Roeck

[permalink] [raw]
Subject: Re: 5.10.144 got more patches? was Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

On 9/19/22 03:33, Pavel Machek wrote:
> Hi!
>
>>> This is the start of the stable review cycle for the 5.10.144 release.
>>> There are 24 patches in this series, all will be posted as a response
>>> to this one. If anyone has any issues with these being applied, please
>>> let me know.
>>
>> CIP testing did not find any problems here:
>>
>> https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/-/tree/linux-5.10.y
>>
>> Tested-by: Pavel Machek (CIP) <[email protected]>
>
> And now I'm confused.
>
> 5.10.144-rc1 was announced / tested, but now there's buch more patches
> in the queue, starting with
>
> |9843b839a 174974 .: 5.10| drm/msm/rd: Fix FIFO-full deadlock
> |518b67da4 174974 .: 4.19| drm/msm/rd: Fix FIFO-full deadlock
> |88eba3686 174974 .: 4.9| drm/msm/rd: Fix FIFO-full deadlock
>

I don't see added commits, but one commit was dropped after the author
complained that it should not be applied to stable releases.

Guenter

2022-09-20 07:57:54

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH 5.10 00/24] 5.10.144-rc1 review

On Sat, Sep 17, 2022 at 6:09 PM Naresh Kamboju
<[email protected]> wrote:
>
> On Fri, 16 Sept 2022 at 15:41, Greg Kroah-Hartman
> <[email protected]> wrote:
> >
> > This is the start of the stable review cycle for the 5.10.144 release.
> > There are 24 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Sun, 18 Sep 2022 10:04:31 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.144-rc1.gz
> > or in the git tree and branch at:
> > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
>
> Results from Linaro's test farm.
> Regressions on x86_64 while running libgpiod tests.
>
> Regressions on x86_64 while running libgpiod tests.
> This reported regression also noticed on mainline, stable-rc 5.19,
> stable-rc 5.15 and stable-rc 5.10 branches
>
> I have not bisected this reported crash yet.
>
> Reported-by: Linux Kernel Functional Testing <[email protected]>
>
> + cd ./automated/linux/gpiod
> + ./gpiod.sh /opt/libgpiod/bin/
> [INFO] libgpiod test suite
> [INFO] 117 tests registered
> [INFO] checking the linux kernel version
> [INFO] kernel release is v5.10.144 - ok to run tests
> [INFO] using gpio-tools from '/usr/bin'
> [ 10.900672] BUG: kernel NULL pointer dereference, address: 00000000000000a0
> [ 10.901452] #PF: supervisor write access in kernel mode
> [ 10.901452] #PF: error_code(0x0002) - not-present page
> [ 10.901452] PGD 108545067 P4D 108545067 PUD 108544067 PMD 0
> [ 10.901452] Oops: 0002 [#1] SMP NOPTI
> [ 10.901452] CPU: 1 PID: 479 Comm: gpiod-test Not tainted 5.10.144-rc1 #1
> [ 10.901452] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996),
> BIOS 1.12.0-1 04/01/2014
> [ 10.901452] RIP: 0010:down_write+0x1a/0x60
> [ 10.901452] Code: 00 31 c0 eb dd e8 76 9e ff ff cc cc cc cc cc cc
> 0f 1f 44 00 00 55 48 89 e5 41 54 49 89 fc e8 4d d9 ff ff 31 c0 ba 01
> 00 00 00 <f0> 49 0f b1 14 24 75 18 65 48 8b 04 25 80 ad 01 00 49 89 44
> 24 08
> [ 10.901452] RSP: 0018:ffffaf1f005abd08 EFLAGS: 00010246
> [ 10.901452] RAX: 0000000000000000 RBX: ffffa38c448f6a80 RCX: ffffff8100000000
> [ 10.901452] RDX: 0000000000000001 RSI: ffffff8100000000 RDI: 00000000000000a0
> [ 10.901452] RBP: ffffaf1f005abd10 R08: 0000000000000286 R09: ffffa38c448f6ad8
> [ 10.901452] R10: 000000000000003e R11: ffffa38c44a4dea8 R12: 00000000000000a0
> [ 10.901452] R13: ffffaf1f005abdb0 R14: 00000000000000a0 R15: ffffa38c44530c40
> [ 10.901452] FS: 00007fbd204f7740(0000) GS:ffffa38c7bc80000(0000)
> knlGS:0000000000000000
> [ 10.901452] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 10.901452] CR2: 00000000000000a0 CR3: 0000000108490000 CR4: 00000000003506e0
> [ 10.901452] Call Trace:
> [ 10.901452] simple_recursive_removal+0x55/0x2b0
> [ 10.901452] ? debugfs_rename+0x2e0/0x2e0
> [ 10.901452] debugfs_remove+0x45/0x70
> [ 10.901452] gpio_mockup_debugfs_cleanup+0x15/0x20 [gpio_mockup]
> [ 10.901452] devm_action_release+0x15/0x20
> [ 10.901452] release_nodes+0x1bd/0x210
> [ 10.901452] devres_release_all+0x3f/0x60
> [ 10.901452] __device_release_driver+0x195/0x260
> [ 10.901452] driver_detach+0xce/0x110
> [ 10.901452] bus_remove_driver+0x5c/0xe0
> [ 10.901452] driver_unregister+0x31/0x60
> [ 10.901452] platform_driver_unregister+0x12/0x20
> [ 10.901452] gpio_mockup_exit+0x1c/0x4c4 [gpio_mockup]
> [ 10.901452] __do_sys_delete_module+0x1b2/0x290
> [ 10.901452] ? syscall_trace_enter.constprop.0+0x13c/0x1b0
> [ 10.901452] __x64_sys_delete_module+0x18/0x20
> [ 10.901452] do_syscall_64+0x38/0x50
> [ 10.901452] entry_SYSCALL_64_after_hwframe+0x61/0xc6
> [ 10.901452] RIP: 0033:0x7fbd2069c95b
> [ 10.901452] Code: 73 01 c3 48 8b 0d c5 34 0e 00 f7 d8 64 89 01 48
> 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00
> 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 95 34 0e 00 f7 d8 64 89
> 01 48
> [ 10.901452] RSP: 002b:00007ffdfa2d9348 EFLAGS: 00000206 ORIG_RAX:
> 00000000000000b0
> [ 10.901452] RAX: ffffffffffffffda RBX: 00000000022af370 RCX: 00007fbd2069c95b
> [ 10.939140] RDX: 00000000022ad8b7 RSI: 0000000000000800 RDI: 00000000022af938
> [ 10.939140] RBP: 00000000022af370 R08: 0000000000000007 R09: 00000000022b75c0
> [ 10.939140] R10: 00007fbd205a6b88 R11: 0000000000000206 R12: 00000000022af420
> [ 10.939140] R13: 00007fbd20743b00 R14: 0000000000418df8 R15: 00007fbd207dc000
> [ 10.939140] Modules linked in: gpio_mockup(-)
> [ 10.939140] CR2: 00000000000000a0
> [ 10.939140] ---[ end trace e891f796dd2f311d ]---
> [ 10.939140] RIP: 0010:down_write+0x1a/0x60
> [ 10.939140] Code: 00 31 c0 eb dd e8 76 9e ff ff cc cc cc cc cc cc
> 0f 1f 44 00 00 55 48 89 e5 41 54 49 89 fc e8 4d d9 ff ff 31 c0 ba 01
> 00 00 00 <f0> 49 0f b1 14 24 75 18 65 48 8b 04 25 80 ad 01 00 49 89 44
> 24 08
> [ 10.939140] RSP: 0018:ffffaf1f005abd08 EFLAGS: 00010246
> [ 10.939140] RAX: 0000000000000000 RBX: ffffa38c448f6a80 RCX: ffffff8100000000
> [ 10.939140] RDX: 0000000000000001 RSI: ffffff8100000000 RDI: 00000000000000a0
> [ 10.939140] RBP: ffffaf1f005abd10 R08: 0000000000000286 R09: ffffa38c448f6ad8
> [ 10.939140] R10: 000000000000003e R11: ffffa38c44a4dea8 R12: 00000000000000a0
> [ 10.939140] R13: ffffaf1f005abdb0 R14: 00000000000000a0 R15: ffffa38c44530c40
> [ 10.939140] FS: 00007fbd204f7740(0000) GS:ffffa38c7bc80000(0000)
> knlGS:0000000000000000
> [ 10.939140] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> [ 10.939140] CR2: 00000000000000a0 CR3: 0000000108490000 CR4: 00000000003506e0
> + ../../utils/send-to-lava.sh result.txt

This is caused by commit 303e6da99429 ("gpio: mockup: remove gpio
debugfs when remove device"). I'm looking into it.

Bart

>
> https://lkft.validation.linaro.org/scheduler/job/5547188#L992
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.143-25-g02c4837d98bf/testrun/11952159/suite/log-parser-test/tests/
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.143-25-g02c4837d98bf/testrun/11954093/suite/log-parser-test/tests/
>
>
> ## Build
> * kernel: 5.10.144-rc1
> * git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
> * git branch: linux-5.10.y
> * git commit: 02c4837d98bf509b70afb8368175c489a5ba7b4a
> * git describe: v5.10.143-25-g02c4837d98bf
> * test details:
> https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.143-25-g02c4837d98bf
>
> ## Test Regressions (compared to v5.10.143)
> - Kernel BUG while running libgpiod on x86_64.
>
> ## No metric Regressions (compared to v5.10.143)
>
> ## No test Fixes (compared to v5.10.143)
>
> ## No metric Fixes (compared to v5.10.143)
>
>
> ## Test result summary
> total: 102380, pass: 89955, fail: 750, skip: 11365, xfail: 310
>
> ## Build Summary
> * arc: 10 total, 10 passed, 0 failed
> * arm: 333 total, 333 passed, 0 failed
> * arm64: 65 total, 63 passed, 2 failed
> * i386: 56 total, 53 passed, 3 failed
> * mips: 56 total, 56 passed, 0 failed
> * parisc: 12 total, 12 passed, 0 failed
> * powerpc: 60 total, 55 passed, 5 failed
> * riscv: 27 total, 27 passed, 0 failed
> * s390: 24 total, 24 passed, 0 failed
> * sh: 24 total, 24 passed, 0 failed
> * sparc: 12 total, 12 passed, 0 failed
> * x86_64: 59 total, 56 passed, 3 failed
>
> ## Test suites summary
> * fwts
> * igt-gpu-tools
> * kunit
> * kvm-unit-tests
> * libhugetlbfs
> * log-parser-boot
> * log-parser-test
> * ltp-cap_bounds
> * ltp-commands
> * ltp-containers
> * ltp-controllers
> * ltp-cpuhotplug
> * ltp-crypto
> * ltp-cve
> * ltp-dio
> * ltp-fcntl-locktests
> * ltp-filecaps
> * ltp-fs
> * ltp-fs_bind
> * ltp-fs_perms_simple
> * ltp-fsx
> * ltp-hugetlb
> * ltp-io
> * ltp-ipc
> * ltp-math
> * ltp-mm
> * ltp-nptl
> * ltp-open-posix-tests
> * ltp-pty
> * ltp-sched
> * ltp-securebits
> * ltp-syscalls
> * ltp-tracing
> * network-basic-tests
> * packetdrill
> * rcutorture
> * v4l2-compliance
> * vdso
>
> --
> Linaro LKFT
> https://lkft.linaro.org