2022-09-17 06:43:23

by williamsukatube

Subject: [PATCH -next] net: sched: simplify code in mall_reoffload

From: William Dean <[email protected]>

such expression:
if (err)
return err;
return 0;
can simplify to:
return err;

Signed-off-by: William Dean <[email protected]>
---
net/sched/cls_matchall.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c
index 06cf22adbab7..63b99ffb7dbc 100644
--- a/net/sched/cls_matchall.c
+++ b/net/sched/cls_matchall.c
@@ -313,10 +313,7 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb,
tc_cleanup_offload_action(&cls_mall.rule->action);
kfree(cls_mall.rule);

- if (err)
- return err;
-
- return 0;
+ return err;
}

static void mall_stats_hw_filter(struct tcf_proto *tp,
--
2.25.1

2022-09-22 02:18:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH -next] net: sched: simplify code in mall_reoffload

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Sat, 17 Sep 2022 14:35:56 +0800 you wrote:
> From: William Dean <[email protected]>
>
> such expression:
> if (err)
> return err;
> return 0;
> can simplify to:
> return err;
>
> [...]

Here is the summary with links:
- [-next] net: sched: simplify code in mall_reoffload
https://git.kernel.org/netdev/net-next/c/2801f30e2cef

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html