Most static warnings are detected by Checkpatch.pl, mainly about:
(1) #1: About the comments.
(2) #2: About function name in a string.
(3) #3: About the open parenthesis.
(4) #4: About the else branch.
(6) #6: About trailing statements.
(7) #5,#7: About blank lines and spaces.
Haoyue Xu (1):
net: ll_temac: Cleanup for function name in a string
huangjunxian (6):
net: ll_temac: fix the format of block comments
net: ll_temac: axienet: align with open parenthesis
net: ll_temac: delete unnecessary else branch
net: ll_temac: fix the missing spaces around '='
net: ll_temac: move trailing statements to next line
net: ll_temac: axienet: delete unnecessary blank lines and spaces
drivers/net/ethernet/xilinx/ll_temac.h | 181 +++++++++---------
drivers/net/ethernet/xilinx/ll_temac_main.c | 65 ++++---
drivers/net/ethernet/xilinx/ll_temac_mdio.c | 6 +-
drivers/net/ethernet/xilinx/xilinx_axienet.h | 2 +-
.../net/ethernet/xilinx/xilinx_axienet_main.c | 6 +-
.../net/ethernet/xilinx/xilinx_axienet_mdio.c | 2 +-
6 files changed, 139 insertions(+), 123 deletions(-)
--
2.30.0
From: huangjunxian <[email protected]>
Cleaning some static warnings of indent.
Signed-off-by: huangjunxian <[email protected]>
Signed-off-by: Haoyue Xu <[email protected]>
---
drivers/net/ethernet/xilinx/ll_temac_main.c | 1 -
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 4 ++--
drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c
index 244070f0cd2a..a74e8872a71e 100644
--- a/drivers/net/ethernet/xilinx/ll_temac_main.c
+++ b/drivers/net/ethernet/xilinx/ll_temac_main.c
@@ -1013,7 +1013,6 @@ static void ll_temac_recv(struct net_device *ndev)
if (((lp->temac_features & TEMAC_FEATURE_RX_CSUM) != 0) &&
(skb->protocol == htons(ETH_P_IP)) &&
(skb->len > 64)) {
-
/* Convert from device endianness (be32) to cpu
* endianness, and if necessary swap the bytes
* (back) for proper IP checksum byte order
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 15d1c8158f31..40581f40716a 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -645,7 +645,7 @@ static int axienet_device_reset(struct net_device *ndev)
* @nr_bds: Max number of descriptors to clean up
* @force: Whether to clean descriptors even if not complete
* @sizep: Pointer to a u32 filled with the total sum of all bytes
- * in all cleaned-up descriptors. Ignored if NULL.
+ * in all cleaned-up descriptors. Ignored if NULL.
* @budget: NAPI budget (use 0 when not called from NAPI poll)
*
* Would either be called after a successful transmit operation, or after
@@ -1375,7 +1375,7 @@ static int axienet_ethtools_get_regs_len(struct net_device *ndev)
static void axienet_ethtools_get_regs(struct net_device *ndev,
struct ethtool_regs *regs, void *ret)
{
- u32 *data = (u32 *) ret;
+ u32 *data = (u32 *)ret;
size_t len = sizeof(u32) * AXIENET_REGS_N;
struct axienet_local *lp = netdev_priv(ndev);
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
index 2772a79cd3ed..0b3b6935c558 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
@@ -126,7 +126,7 @@ static int axienet_mdio_write(struct mii_bus *bus, int phy_id, int reg,
return ret;
}
- axienet_iow(lp, XAE_MDIO_MWD_OFFSET, (u32) val);
+ axienet_iow(lp, XAE_MDIO_MWD_OFFSET, (u32)val);
axienet_iow(lp, XAE_MDIO_MCR_OFFSET,
(((phy_id << XAE_MDIO_MCR_PHYAD_SHIFT) &
XAE_MDIO_MCR_PHYAD_MASK) |
--
2.30.0
On Sat, Sep 17, 2022 at 4:10 PM Haoyue Xu <[email protected]> wrote:
>
> Most static warnings are detected by Checkpatch.pl, mainly about:
> (1) #1: About the comments.
> (2) #2: About function name in a string.
> (3) #3: About the open parenthesis.
> (4) #4: About the else branch.
> (6) #6: About trailing statements.
> (7) #5,#7: About blank lines and spaces.
Thank you. For the series:
Reviewed-by: Harini Katakam <[email protected]>
Regards,
Harini
Hello:
This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Sat, 17 Sep 2022 18:38:36 +0800 you wrote:
> Most static warnings are detected by Checkpatch.pl, mainly about:
> (1) #1: About the comments.
> (2) #2: About function name in a string.
> (3) #3: About the open parenthesis.
> (4) #4: About the else branch.
> (6) #6: About trailing statements.
> (7) #5,#7: About blank lines and spaces.
>
> [...]
Here is the summary with links:
- [net-next,1/7] net: ll_temac: fix the format of block comments
https://git.kernel.org/netdev/net-next/c/75124116520b
- [net-next,2/7] net: ll_temac: Cleanup for function name in a string
https://git.kernel.org/netdev/net-next/c/653de988eb58
- [net-next,3/7] net: ll_temac: axienet: align with open parenthesis
https://git.kernel.org/netdev/net-next/c/42f5d4d0e0d9
- [net-next,4/7] net: ll_temac: delete unnecessary else branch
https://git.kernel.org/netdev/net-next/c/7dfd0dcc5e72
- [net-next,5/7] net: ll_temac: fix the missing spaces around '='
https://git.kernel.org/netdev/net-next/c/a9f1ef7034b8
- [net-next,6/7] net: ll_temac: move trailing statements to next line
https://git.kernel.org/netdev/net-next/c/a0a850976801
- [net-next,7/7] net: ll_temac: axienet: delete unnecessary blank lines and spaces
https://git.kernel.org/netdev/net-next/c/7fe85bb3af4e
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html