2022-09-18 15:39:21

by CGEL

[permalink] [raw]
Subject: [PATCH linu-next] mm/fault: fix comparing pointer to 0

From: Xu Panda <[email protected]>

Do not use assignment in if condition,
and using "!P" instead of comparing pointer to 0.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Xu Panda <[email protected]>
---
arch/alpha/mm/fault.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/alpha/mm/fault.c b/arch/alpha/mm/fault.c
index ef427a6bdd1a..09d0d069059b 100644
--- a/arch/alpha/mm/fault.c
+++ b/arch/alpha/mm/fault.c
@@ -194,7 +194,8 @@ do_page_fault(unsigned long address, unsigned long mmcsr,

no_context:
/* Are we prepared to handle this fault as an exception? */
- if ((fixup = search_exception_tables(regs->pc)) != 0) {
+ fixup = search_exception_tables(regs->pc);
+ if (!fixup) {
unsigned long newpc;
newpc = fixup_exception(dpf_reg, fixup, regs->pc);
regs->pc = newpc;
--
2.15.2