2022-09-19 11:22:03

by Mehta, Piyush

Subject: [PATCH V2 1/2] dt-bindings: usb: snps,dwc3: Add 'snps,resume-hs-terminations' quirk

From: Piyush Mehta <[email protected]>

Add a new 'snps,resume-hs-terminations' DT quirk to dwc3 core to resolved
issue of CRC failed error.

On the resume path, U3/U2 exit controller fails to send proper CRC checksum
in CRC5 field. As result Transaction Error is generated. Enabling bit 10 of
GUCTL1 will correct this problem.

When this bit is set to '1', the UTMI/ULPI opmode will be changed to
"normal" along with HS terminations and term/xcvr select signals after EOR.
This option is to support certain legacy UTMI/ULPI PHYs.

Signed-off-by: Piyush Mehta <[email protected]>
Signed-off-by: Piyush Mehta <[email protected]>
---
Changes in V2:
- Addressed Krzysztof Kozlowski review comments
- Update the quirk name and No underscores in properties.
- Modified the quirk description.
Link: https://lore.kernel.org/all/[email protected]/
---
Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
index 1779d08ba1c0..534f5b42e056 100644
--- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml
@@ -234,6 +234,13 @@ properties:
avoid -EPROTO errors with usbhid on some devices (Hikey 970).
type: boolean

+ snps,resume-hs-terminations:
+ description:
+ Fix the issue of HS terminations CRC error on resume by enabling this
+ quirk. When set, all the termsel, xcvrsel, opmode becomes 0 during end
+ of resume. This option is to support certain legacy ULPI PHYs.
+ type: boolean
+
snps,is-utmi-l1-suspend:
description:
True when DWC3 asserts output signal utmi_l1_suspend_n, false when
--
2.25.1

2022-09-19 13:11:47

by Krzysztof Kozlowski

Subject: Re: [PATCH V2 1/2] dt-bindings: usb: snps,dwc3: Add 'snps,resume-hs-terminations' quirk

On 19/09/2022 12:48, Piyush Mehta wrote:
> From: Piyush Mehta <[email protected]>
>
> Add a new 'snps,resume-hs-terminations' DT quirk to dwc3 core to resolved
> issue of CRC failed error.
>
> On the resume path, U3/U2 exit controller fails to send proper CRC checksum
> in CRC5 field. As result Transaction Error is generated. Enabling bit 10 of
> GUCTL1 will correct this problem.
>
> When this bit is set to '1', the UTMI/ULPI opmode will be changed to
> "normal" along with HS terminations and term/xcvr select signals after EOR.
> This option is to support certain legacy UTMI/ULPI PHYs.
>
> Signed-off-by: Piyush Mehta <[email protected]>
> Signed-off-by: Piyush Mehta <[email protected]>

Only one SoB is needed for one person. For example switch to amd.com
(with ownership of commit) or skip second SoB.

> ---
> Changes in V2:
> - Addressed Krzysztof Kozlowski review comments
> - Update the quirk name and No underscores in properties.
> - Modified the quirk description.
> Link: https://lore.kernel.org/all/[email protected]/
> ---
> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof