2022-09-19 14:51:48

by Prabhakar

Subject: [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name

From: Lad Prabhakar <[email protected]>

The OV5645 sensor has a single clock source, so just drop fetching the
clk reference by name.

This is in preparation to drop the "clock-names" property from the DT
binding.

Suggested-by: Laurent Pinchart <[email protected]>
Signed-off-by: Lad Prabhakar <[email protected]>
---
drivers/media/i2c/ov5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
index 81e4e87e1821..47451238ca05 100644
--- a/drivers/media/i2c/ov5645.c
+++ b/drivers/media/i2c/ov5645.c
@@ -1090,7 +1090,7 @@ static int ov5645_probe(struct i2c_client *client)
}

/* get system clock (xclk) */
- ov5645->xclk = devm_clk_get(dev, "xclk");
+ ov5645->xclk = devm_clk_get(dev, NULL);
if (IS_ERR(ov5645->xclk)) {
dev_err(dev, "could not get xclk");
return PTR_ERR(ov5645->xclk);
--
2.25.1

2022-09-19 14:53:09

by Laurent Pinchart

Subject: Re: [PATCH] media: i2c: ov5645: Drop fetching the clk reference by name

Hi Prabhakar,

Thank you for the patch.

On Mon, Sep 19, 2022 at 03:33:50PM +0100, Prabhakar wrote:
> From: Lad Prabhakar <[email protected]>
>
> The OV5645 sensor has a single clock source, so just drop fetching the
> clk reference by name.
>
> This is in preparation to drop the "clock-names" property from the DT
> binding.
>
> Suggested-by: Laurent Pinchart <[email protected]>
> Signed-off-by: Lad Prabhakar <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/ov5645.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
> index 81e4e87e1821..47451238ca05 100644
> --- a/drivers/media/i2c/ov5645.c
> +++ b/drivers/media/i2c/ov5645.c
> @@ -1090,7 +1090,7 @@ static int ov5645_probe(struct i2c_client *client)
> }
>
> /* get system clock (xclk) */
> - ov5645->xclk = devm_clk_get(dev, "xclk");
> + ov5645->xclk = devm_clk_get(dev, NULL);
> if (IS_ERR(ov5645->xclk)) {
> dev_err(dev, "could not get xclk");
> return PTR_ERR(ov5645->xclk);

--
Regards,

Laurent Pinchart