2022-09-20 07:16:34

by CGEL

Subject: [PATCH linux-next] ALSA: es18xx: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value inb() directly instead of storing it in another redundant
variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
sound/isa/es18xx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c
index 3fcd168480b6..0a32845b1017 100644
--- a/sound/isa/es18xx.c
+++ b/sound/isa/es18xx.c
@@ -1344,11 +1344,8 @@ ES18XX_SINGLE("GPO1 Switch", 0, ES18XX_PM, 1, 1, ES18XX_FL_PMPORT),

static int snd_es18xx_config_read(struct snd_es18xx *chip, unsigned char reg)
{
- int data;
-
outb(reg, chip->ctrl_port);
- data = inb(chip->ctrl_port + 1);
- return data;
+ return inb(chip->ctrl_port + 1);
}

static void snd_es18xx_config_write(struct snd_es18xx *chip,
--
2.25.1

2022-09-20 11:49:26

by Takashi Iwai

Subject: Re: [PATCH linux-next] ALSA: es18xx: Remove the unneeded result variable

On Tue, 20 Sep 2022 08:46:05 +0200,
[email protected] wrote:
>
> From: ye xingchen <[email protected]>
>
> Return the value inb() directly instead of storing it in another redundant
> variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: ye xingchen <[email protected]>

Thanks, applied.


Takashi