2022-09-20 07:15:22

by CGEL

Subject: [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable

From: ye xingchen <[email protected]>

Return the value amx3_common_init() directly instead of storing it in
another redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: ye xingchen <[email protected]>
---
arch/arm/mach-omap2/pm33xx-core.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
index bf0d25fd2cea..4b29d8323ffc 100644
--- a/arch/arm/mach-omap2/pm33xx-core.c
+++ b/arch/arm/mach-omap2/pm33xx-core.c
@@ -105,8 +105,6 @@ static int amx3_common_init(int (*idle)(u32 wfi_flags))

static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
{
- int ret;
-
gfx_l4ls_clkdm = clkdm_lookup("gfx_l4ls_gfx_clkdm");

if (!gfx_l4ls_clkdm) {
@@ -114,9 +112,7 @@ static int am33xx_suspend_init(int (*idle)(u32 wfi_flags))
return -ENODEV;
}

- ret = amx3_common_init(idle);
-
- return ret;
+ return amx3_common_init(idle);
}

static int am43xx_suspend_init(int (*idle)(u32 wfi_flags))
--
2.25.1

2023-03-28 05:47:35

by Tony Lindgren

Subject: Re: [PATCH linux-next] ARM: OMAP2+: Remove the unneeded result variable

* [email protected] <[email protected]> [220920 09:43]:
> From: ye xingchen <[email protected]>
>
> Return the value amx3_common_init() directly instead of storing it in
> another redundant variable.

Thanks applying into omap-for-v6.4/cleanup.

Tony