2022-09-21 01:47:42

by Peilin Ye

[permalink] [raw]
Subject: [PATCH net] udp: Use WARN_ON_ONCE() in udp_read_skb()

From: Peilin Ye <[email protected]>

Prevent udp_read_skb() from flooding the syslog.

Suggested-by: Jakub Sitnicki <[email protected]>
Signed-off-by: Peilin Ye <[email protected]>
---
net/ipv4/udp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index cd72158e953a..560d9eadeaa5 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1821,7 +1821,7 @@ int udp_read_skb(struct sock *sk, skb_read_actor_t recv_actor)
continue;
}

- WARN_ON(!skb_set_owner_sk_safe(skb, sk));
+ WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk));
used = recv_actor(sk, skb);
if (used <= 0) {
if (!copied)
--
2.20.1


2022-09-22 14:28:09

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net] udp: Use WARN_ON_ONCE() in udp_read_skb()

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 20 Sep 2022 17:59:15 -0700 you wrote:
> From: Peilin Ye <[email protected]>
>
> Prevent udp_read_skb() from flooding the syslog.
>
> Suggested-by: Jakub Sitnicki <[email protected]>
> Signed-off-by: Peilin Ye <[email protected]>
>
> [...]

Here is the summary with links:
- [net] udp: Use WARN_ON_ONCE() in udp_read_skb()
https://git.kernel.org/netdev/net/c/db39dfdc1c3b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html